Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1244)

Issue 1030283003: X87: Switch full-codegen from StackHandlers to handler table. (Closed)

Created:
5 years, 9 months ago by chunyang.dai
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Switch full-codegen from StackHandlers to handler table. port 38a719f965d0a83ddac04392d5b9c5abe214281c (r27440) original commit message: This switches full-codegen to no longer push and pop StackHandler markers onto the operand stack, but relies on a range-based handler table instead. We only use StackHandlers in JSEntryStubs to mark the transition from C to JS code. Note that this makes deoptimization and OSR from within any try-block work out of the box, makes the non-exception paths faster and should overall be neutral on the memory footprint (pros). On the other hand it makes the exception paths slower and actually throwing and exception more expensive (cons). BUG= Committed: https://crrev.com/1caa6179d2c71c3f50b7f7bc41d0cf6031133e6a Cr-Commit-Position: refs/heads/master@{#27478}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -62 lines) Patch
M src/x87/code-stubs-x87.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M src/x87/full-codegen-x87.cc View 5 chunks +8 lines, -34 lines 0 comments Download
M src/x87/macro-assembler-x87.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 1 chunk +4 lines, -17 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
chunyang.dai
PTAL.
5 years, 9 months ago (2015-03-26 09:50:44 UTC) #2
Michael Starzinger
LGTM.
5 years, 9 months ago (2015-03-26 12:40:30 UTC) #4
Weiliang
lgtm
5 years, 9 months ago (2015-03-26 12:41:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1030283003/1
5 years, 9 months ago (2015-03-26 12:41:47 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-26 13:06:53 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 13:07:04 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1caa6179d2c71c3f50b7f7bc41d0cf6031133e6a
Cr-Commit-Position: refs/heads/master@{#27478}

Powered by Google App Engine
This is Rietveld 408576698