pdf skp tabl_worldjournal.skp took 5 days to run on Valgrind

pdf skp tabl_worldjournal.skp took 5 days to run on Valgrind

 #notry

BUG=skia:
NOTRY=true

Committed: https://skia.googlesource.com/skia/+/ce866873102e70421d9e532f19cf56905482054e

[mtklein, 2015-03-26 12:11:50]

mtklein@google.com changed reviewers:
+ borenet@google.com, halcanary@google.com, mtklein@google.com

[mtklein, 2015-03-26 12:11:50]

The CQ bit was checked by mtklein@google.com

[mtklein, 2015-03-26 12:11:50]

lgtm

[commit-bot: I haz the power, 2015-03-26 12:12:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1030263003/1

[commit-bot: I haz the power, 2015-03-26 12:12:17]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ce866873102e70421d9e532f19cf56905482054e

[borenet, 2015-03-26 12:12:31]

Ouch. LGTM

[reed1, 2015-03-26 12:58:13]

reed@google.com changed reviewers:
+ reed@google.com

[reed1, 2015-03-26 12:58:14]

have we profiled to understand what this site is triggering in our code?

[mtklein, 2015-03-26 13:15:08]

On 2015/03/26 12:58:14, reed1 wrote:
> have we profiled to understand what this site is triggering in our code?

On my laptop, I see ~55% of the time consumed by compressing the PDF catalog,
and the next ~35% is font-related: deserializing the fonts from the SKP, getting
their metrics.

We have a known open issue around not doing font subsetting in PDF on our bots. 
That's likely a contributor here, both making the catalog much larger than it
needs to be and generally overstressing our font code.

Profiling when running under Valgrind itself doesn't showing anything useful (no
symbols).  I'd assume same there, but much slower.

[mtklein, 2015-03-26 13:16:20]

On 2015/03/26 13:15:08, mtklein wrote:
> On 2015/03/26 12:58:14, reed1 wrote:
> > have we profiled to understand what this site is triggering in our code?
> 
> On my laptop, I see ~55% of the time consumed by compressing the PDF catalog,
> and the next ~35% is font-related: deserializing the fonts from the SKP,
getting
> their metrics.
> 
> We have a known open issue around not doing font subsetting in PDF on our
bots. 
> That's likely a contributor here, both making the catalog much larger than it
> needs to be and generally overstressing our font code.
> 
> Profiling when running under Valgrind itself doesn't showing anything useful
(no
> symbols).  I'd assume same there, but much slower.

That all said, this takes about 1.5s to run in Release normally, and about 30s
to run in Release under Valgrind.  Something really wonky's going on to make it
to run for 5 days.