chrome/browser/devtools/devtools_target_impl.cc - Issue 1030263002: favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/devtools

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/devtools_target_impl.cc

Issue 1030263002: favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/devtools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/devtools/devtools_target_impl.cc

diff --git a/chrome/browser/devtools/devtools_target_impl.cc b/chrome/browser/devtools/devtools_target_impl.cc

index b03a737b5074b59b3d445b4bb642323fec3640ff..be739263be39a76c2fc5dc742ba65981876c67e2 100644

--- a/chrome/browser/devtools/devtools_target_impl.cc

+++ b/chrome/browser/devtools/devtools_target_impl.cc

@@ -272,7 +272,7 @@ scoped_ptr<DevToolsTargetImpl> DevToolsTargetImpl::CreateForWebContents(

// static

void DevToolsTargetImpl::EnumerateAllTargets(Callback callback) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

std::set<WebContents*> tab_web_contents;

for (TabContentsIterator it; !it.done(); it.Next())

« no previous file with comments | « chrome/browser/devtools/devtools_file_system_indexer.cc ('k') | chrome/browser/devtools/devtools_targets_ui.cc » ('j') | no next file with comments »