Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 1030253003: mac: Remove the unused UMA histogram OSX.CatSixtyFour. (Closed)

Created:
5 years, 9 months ago by erikchen
Modified:
5 years, 9 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mac: Remove the unused UMA histogram OSX.CatSixtyFour. The histogram was used for the 64bit transition. Is it no longer useful. BUG= Committed: https://crrev.com/7fce85a88b57b7b08762690ed9c763ba319f9af8 Cr-Commit-Position: refs/heads/master@{#322258}

Patch Set 1 : #

Total comments: 1

Patch Set 2 : Comments from isherman. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -123 lines) Patch
M chrome/browser/chrome_browser_main_mac.mm View 3 chunks +0 lines, -123 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
erikchen
mark: Please review.
5 years, 9 months ago (2015-03-25 18:49:33 UTC) #3
Mark Mentovai
LGTM<
5 years, 9 months ago (2015-03-25 18:51:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1030253003/20001
5 years, 9 months ago (2015-03-25 18:52:40 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/51860)
5 years, 9 months ago (2015-03-25 19:05:26 UTC) #8
erikchen
isherman: Looking for an OWNER review of tools/metrics/histograms/histograms.xml
5 years, 9 months ago (2015-03-25 19:07:16 UTC) #10
Ilya Sherman
Hooray for cleanup! https://codereview.chromium.org/1030253003/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/1030253003/diff/20001/tools/metrics/histograms/histograms.xml#oldcode24163 tools/metrics/histograms/histograms.xml:24163: -</histogram> Please mark this as <obsolete ...
5 years, 9 months ago (2015-03-25 20:31:35 UTC) #11
erikchen
isherman: PTAL
5 years, 9 months ago (2015-03-25 21:11:59 UTC) #12
Ilya Sherman
LGTM, thanks :)
5 years, 9 months ago (2015-03-25 21:17:56 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1030253003/40001
5 years, 9 months ago (2015-03-25 21:18:55 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 9 months ago (2015-03-25 23:15:05 UTC) #17
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 23:15:59 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7fce85a88b57b7b08762690ed9c763ba319f9af8
Cr-Commit-Position: refs/heads/master@{#322258}

Powered by Google App Engine
This is Rietveld 408576698