Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: lib/src/js/nodes.dart

Issue 1030243002: [cleanup] remove PropertyName from js_ast (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/src/js/nodes.dart
diff --git a/lib/src/js/nodes.dart b/lib/src/js/nodes.dart
index 39fcbfb8ca69a2e264b09ab8dd26b9e51f65a36d..370bbfe0ef0e66cc1ce457f290864e174cda257f 100644
--- a/lib/src/js/nodes.dart
+++ b/lib/src/js/nodes.dart
@@ -70,7 +70,6 @@ abstract class NodeVisitor<T> {
T visitClassDeclaration(ClassDeclaration node);
T visitClassExpression(ClassExpression node);
T visitMethod(Method node);
- T visitPropertyName(PropertyName node);
T visitComment(Comment node);
T visitCommentExpression(CommentExpression node);
@@ -81,7 +80,6 @@ abstract class NodeVisitor<T> {
T visitInterpolatedSelector(InterpolatedSelector node);
T visitInterpolatedStatement(InterpolatedStatement node);
T visitInterpolatedMethod(InterpolatedMethod node);
- T visitInterpolatedPropertyName(InterpolatedPropertyName node);
T visitInterpolatedVariableDeclaration(InterpolatedVariableDeclaration node);
}
@@ -174,7 +172,6 @@ class BaseVisitor<T> implements NodeVisitor<T> {
T visitClassDeclaration(ClassDeclaration node) => visitStatement(node);
T visitClassExpression(ClassExpression node) => visitExpression(node);
T visitMethod(Method node) => visitProperty(node);
- T visitPropertyName(PropertyName node) => visitExpression(node);
T visitInterpolatedNode(InterpolatedNode node) => visitNode(node);
@@ -190,8 +187,6 @@ class BaseVisitor<T> implements NodeVisitor<T> {
=> visitInterpolatedNode(node);
T visitInterpolatedMethod(InterpolatedMethod node)
=> visitInterpolatedNode(node);
- T visitInterpolatedPropertyName(InterpolatedPropertyName node)
- => visitInterpolatedNode(node);
T visitInterpolatedVariableDeclaration(InterpolatedVariableDeclaration node)
=> visitInterpolatedNode(node);
@@ -857,16 +852,6 @@ class VariableDeclaration extends VariableReference {
VariableDeclaration _clone() => new VariableDeclaration(name);
}
-class PropertyName extends Expression {
- final String name;
- PropertyName(this.name);
-
- accept(NodeVisitor visitor) => visitor.visitPropertyName(this);
- visitChildren(NodeVisitor visitor) {}
- int get precedenceLevel => PRIMARY;
- PropertyName _clone() => new PropertyName(name);
-}
-
class Parameter extends VariableDeclaration {
Parameter(String name) : super(name);
@@ -1309,22 +1294,6 @@ class InterpolatedMethod extends Expression with InterpolatedNode
get _unsupported => throw '$runtimeType does not support this member.';
}
-class InterpolatedPropertyName extends Expression with InterpolatedNode
- implements PropertyName {
- final nameOrPosition;
-
- InterpolatedPropertyName(this.nameOrPosition);
-
- accept(NodeVisitor visitor) => visitor.visitInterpolatedPropertyName(this);
- void visitChildren(NodeVisitor visitor) {}
- InterpolatedPropertyName _clone() =>
- new InterpolatedPropertyName(nameOrPosition);
-
- int get precedenceLevel => PRIMARY;
- String get name => throw '$runtimeType does not support this member.';
- bool get allowRename => false;
-}
-
class InterpolatedVariableDeclaration extends Expression with InterpolatedNode
implements VariableDeclaration {
final nameOrPosition;

Powered by Google App Engine
This is Rietveld 408576698