Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 1030243002: [cleanup] remove PropertyName from js_ast (Closed)

Created:
5 years, 9 months ago by Jennifer Messerly
Modified:
5 years, 9 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove PropertyName from js_ast This was added to our version, while still figuring out js_ast. As it is now, Printer handles property names quite well on its own, so the extra AST node doesn't add anything. R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/1bd6154e46823780f7297534c8b35015e7e6bc85

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -87 lines) Patch
M lib/src/codegen/js_codegen.dart View 1 8 chunks +14 lines, -10 lines 0 comments Download
M lib/src/js/builder.dart View 4 chunks +17 lines, -20 lines 0 comments Download
M lib/src/js/nodes.dart View 6 chunks +0 lines, -31 lines 0 comments Download
M lib/src/js/printer.dart View 3 chunks +2 lines, -12 lines 0 comments Download
M lib/src/js/template.dart View 2 chunks +0 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Jennifer Messerly
Just a small cleanup. I'm working on other changes related to names/temps but this seemed ...
5 years, 9 months ago (2015-03-25 18:26:42 UTC) #2
vsm
lgtm https://codereview.chromium.org/1030243002/diff/1/lib/src/codegen/js_codegen.dart File lib/src/codegen/js_codegen.dart (right): https://codereview.chromium.org/1030243002/diff/1/lib/src/codegen/js_codegen.dart#newcode341 lib/src/codegen/js_codegen.dart:341: js.string(name, "'"), Did you mean to use _propertyName ...
5 years, 9 months ago (2015-03-25 19:44:28 UTC) #3
Jennifer Messerly
Thanks! https://codereview.chromium.org/1030243002/diff/1/lib/src/codegen/js_codegen.dart File lib/src/codegen/js_codegen.dart (right): https://codereview.chromium.org/1030243002/diff/1/lib/src/codegen/js_codegen.dart#newcode341 lib/src/codegen/js_codegen.dart:341: js.string(name, "'"), On 2015/03/25 19:44:27, vsm wrote: > ...
5 years, 9 months ago (2015-03-25 20:28:52 UTC) #4
Jennifer Messerly
5 years, 9 months ago (2015-03-25 20:28:59 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
1bd6154e46823780f7297534c8b35015e7e6bc85 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698