chrome/browser/extensions/extension_special_storage_policy.cc - Issue 1030133002: Move the check for fileBrowserHandler permission to FileBrowserHandler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_special_storage_policy.cc

Issue 1030133002: Move the check for fileBrowserHandler permission to FileBrowserHandler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed manifests, tests + added a test. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_special_storage_policy.h ('k') | chrome/browser/extensions/mock_extension_special_storage_policy.h » ('j') | chrome/common/extensions/api/file_browser_handlers/file_browser_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_special_storage_policy.cc

diff --git a/chrome/browser/extensions/extension_special_storage_policy.cc b/chrome/browser/extensions/extension_special_storage_policy.cc

index 06c5dc2127e946d8428f25a335ae014706f6fa43..102d11bb3cb522a58bdb772fab8b8e84388760c5 100644

--- a/chrome/browser/extensions/extension_special_storage_policy.cc

+++ b/chrome/browser/extensions/extension_special_storage_policy.cc

@@ -129,12 +129,6 @@ bool ExtensionSpecialStoragePolicy::HasSessionOnlyOrigins() {

return false;

}

-bool ExtensionSpecialStoragePolicy::IsFileHandler(

- const std::string& extension_id) {

- base::AutoLock locker(lock_);

- return file_handler_extensions_.ContainsExtension(extension_id);

bool ExtensionSpecialStoragePolicy::HasIsolatedStorage(const GURL& origin) {

base::AutoLock locker(lock_);

return isolated_extensions_.Contains(origin);