Move the check for fileBrowserHandler permission to FileBrowserHandler.

chrome/common/extensions/api/file_browser_handlers/file_browser_handler.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/api/file_browser_handlers/file_browser_handler.h"
 
 #include "base/logging.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/values.h"
 #include "chrome/common/extensions/extension_constants.h"
 #include "extensions/common/error_utils.h"
 #include "extensions/common/manifest.h"
 #include "extensions/common/manifest_constants.h"
+#include "extensions/common/manifest_handlers/permissions_parser.h"
+#include "extensions/common/permissions/api_permission.h"
 #include "extensions/common/url_pattern.h"
 #include "url/url_constants.h"
 
 namespace keys = extensions::manifest_keys;
 namespace errors = extensions::manifest_errors;
 
 namespace {
 
 const char kReadAccessString[] = "read";
 const char kReadWriteAccessString[] = "read-write";
@@ skipping 82 matching lines @@
 }
 
 bool FileBrowserHandler::HasCreateAccessPermission() const {
   DCHECK(!(file_access_permission_flags_ & kInvalidPermission));
   return (file_access_permission_flags_ & kCreatePermission) != 0;
 }
 
 // static
 FileBrowserHandler::List*
 FileBrowserHandler::GetHandlers(const extensions::Extension* extension) {
-  FileBrowserHandlerInfo* info = static_cast<FileBrowserHandlerInfo*>(
+  FileBrowserHandlerInfo* const info = static_cast<FileBrowserHandlerInfo*>(
       extension->GetManifestData(keys::kFileBrowserHandlers));
-  if (info)
-    return &info->file_browser_handlers;
-  return NULL;
+  if (!info)
+    return nullptr;
+
+  return &info->file_browser_handlers;
 }
 
 FileBrowserHandlerParser::FileBrowserHandlerParser() {
 }
 
 FileBrowserHandlerParser::~FileBrowserHandlerParser() {
 }
 
 namespace {
 
@@ skipping 128 matching lines @@
       return false;  // Failed to parse file browser action definition.
     result->push_back(linked_ptr<FileBrowserHandler>(action.release()));
   }
   return true;
 }
 
 }  // namespace
 
 bool FileBrowserHandlerParser::Parse(extensions::Extension* extension,
                                      base::string16* error) {
+  // If the permission is missing, then skip parsing the list of handlers.

[Yoyo Zhou, 2015/03/26 01:31:32]

I think it would be helpful to add an install warning (AddInstallWarning) if we
have no permission but some handlers.

[mtomasz, 2015/03/26 01:35:32]

Agreed. Let me do it in a separate CL, as this one is already very big.

+  if (!extensions::PermissionsParser::HasAPIPermission(
+          extension, extensions::APIPermission::ID::kFileBrowserHandler)) {
+    return true;
+  }
+
   const base::ListValue* file_browser_handlers_value = NULL;
   if (!extension->manifest()->GetList(keys::kFileBrowserHandlers,
                                       &file_browser_handlers_value)) {
     *error = base::ASCIIToUTF16(errors::kInvalidFileBrowserHandler);
     return false;
   }
+
   scoped_ptr<FileBrowserHandlerInfo> info(new FileBrowserHandlerInfo);
   if (!LoadFileBrowserHandlers(extension->id(),
                                file_browser_handlers_value,
                                &info->file_browser_handlers,
                                error)) {
     return false;  // Failed to parse file browser actions definition.
   }
 
   extension->SetManifestData(keys::kFileBrowserHandlers, info.release());
   return true;
 }
 
 const std::vector<std::string> FileBrowserHandlerParser::Keys() const {
   return SingleKey(keys::kFileBrowserHandlers);
 }