Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 103013004: Google drive forms should not appear in the "offline" tab of Files.app. (Closed)

Created:
6 years, 11 months ago by kinaba
Modified:
6 years, 11 months ago
Reviewers:
hirono
CC:
chromium-reviews, tfarina, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Google drive forms should not appear in the "offline" tab of Files.app. They are not offline available. See the comments added in the patch and metadata_cache.js. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243361

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -11 lines) Patch
M chrome/browser/chromeos/drive/search_metadata.cc View 2 chunks +19 lines, -5 lines 0 comments Download
M google_apis/drive/gdata_wapi_parser.h View 1 chunk +3 lines, -0 lines 0 comments Download
M google_apis/drive/gdata_wapi_parser.cc View 2 chunks +12 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kinaba
6 years, 11 months ago (2014-01-07 06:37:50 UTC) #1
hirono
lgtm. Thank you for fixing it!
6 years, 11 months ago (2014-01-07 11:34:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/103013004/1
6 years, 11 months ago (2014-01-07 14:30:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/103013004/1
6 years, 11 months ago (2014-01-07 15:28:00 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-07 19:37:47 UTC) #5
Message was sent while issue was closed.
Change committed as 243361

Powered by Google App Engine
This is Rietveld 408576698