Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 103013003: [SyncFS] Move APIUtil constants to V2 directory. (Closed)

Created:
6 years, 11 months ago by tzik
Modified:
6 years, 11 months ago
Reviewers:
kinuko, nhiroki
CC:
chromium-reviews, kinuko+watch, nhiroki, tzik
Visibility:
Public.

Description

[SyncFS] Move APIUtil constants to V2 directory. * Move shared constants between V1 and V2 to drive_backend_constants. * Drop dependency from FakeDriveServiceHelper to APIUtil BUG=331991 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243523

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -26 lines) Patch
M chrome/browser/sync_file_system/drive_backend/conflict_resolver_unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_backend_constants.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_backend_constants.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_backend_sync_unittest.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_backend_util.cc View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/list_changes_task_unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer_unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/register_app_task_unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer_unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend_v1/api_util.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend_v1/api_util_unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend_v1/drive_file_sync_service_fake_unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend_v1/drive_file_sync_service_sync_unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend_v1/fake_drive_service_helper.h View 1 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend_v1/fake_drive_service_helper.cc View 1 3 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
tzik
PTL
6 years, 11 months ago (2014-01-07 06:38:11 UTC) #1
nhiroki
lgtm
6 years, 11 months ago (2014-01-07 06:47:58 UTC) #2
kinuko
lgtm
6 years, 11 months ago (2014-01-07 09:43:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/103013003/20001
6 years, 11 months ago (2014-01-07 10:32:12 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) nacl_integration http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=242348
6 years, 11 months ago (2014-01-07 13:08:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/103013003/20001
6 years, 11 months ago (2014-01-07 13:47:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/103013003/20001
6 years, 11 months ago (2014-01-07 15:27:38 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) nacl_integration http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=242526
6 years, 11 months ago (2014-01-07 19:33:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/103013003/20001
6 years, 11 months ago (2014-01-08 00:35:05 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) nacl_integration http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=242981
6 years, 11 months ago (2014-01-08 04:51:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/103013003/420001
6 years, 11 months ago (2014-01-08 05:28:51 UTC) #11
commit-bot: I haz the power
6 years, 11 months ago (2014-01-08 12:05:50 UTC) #12
Message was sent while issue was closed. 
Change committed as 243523

Powered by Google App Engine
This is Rietveld 408576698