components/autofill/core/browser/autofill_regex_constants.cc.utf8 - Issue 1030073003: Autofill: Better recognize credit card type fields.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_regex_constants.cc.utf8

Issue 1030073003: Autofill: Better recognize credit card type fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: after Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/core/browser/autofill_field.cc ('K') | « components/autofill/core/browser/autofill_field.cc ('k') | components/autofill/core/browser/credit_card_field.h » ('j') | components/autofill/core/browser/credit_card_field.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autofill_regex_constants.cc.utf8

diff --git a/components/autofill/core/browser/autofill_regex_constants.cc.utf8 b/components/autofill/core/browser/autofill_regex_constants.cc.utf8

index 7339f8a26b12d99913fda35597260c37bc40d385..22cc38615236daab329093c9d949acedc9f7b80c 100644

--- a/components/autofill/core/browser/autofill_regex_constants.cc.utf8

+++ b/components/autofill/core/browser/autofill_regex_constants.cc.utf8

@@ -149,8 +149,6 @@ const char kCardCvcRe[] =

"verification|card identification|security code|card code"

"|cvn|cvv|cvc|csc|cvd|cid|ccv"

"|\\bcid\\b";

-const char kCardTypeRe[] =

- "(card|cc|payment).?type|payment.?method|card.*brand";

// "Expiration date" is the most common label here, but some pages have

// "Expires", "exp. date" or "exp. month" and "exp. year". We also look

@@ -197,8 +195,6 @@ const char kExpirationDateRe[] =

"|有効期限" // ja-JP

"|validade" // pt-BR, pt-PT

"|Срок действия карты"; // ru

-const char kCardIgnoredRe[] =

- "^card";

const char kGiftCardRe[] =

"gift.?card";