more care around generated names, fixes #60 #82 and #97

more care around generated names, fixes #60 #82 and #97

R=vsm@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/e4524f18d0eb6d1ca61fd04678485f5d22a25a81

[Jennifer Messerly, 2015-03-26 21:53:43]

jmesserly@google.com changed reviewers:
+ vsm@google.com

[Jennifer Messerly, 2015-03-26 21:55:50]

we still need to be careful to use the temporary, if we want the variable to
support renaming, otherwise it can't be renamed. I originally tried the reverse,
and had bound names that shared an Element pointer, and temporaries as raw
strings. But that seemed a bit more complex. We might get there but this variant
seemed to require fewer changes to get decent output.

[vsm, 2015-03-27 00:19:53]

lgtm

[Jennifer Messerly, 2015-03-27 00:47:35]

Committed patchset #1 (id:1) manually as
e4524f18d0eb6d1ca61fd04678485f5d22a25a81 (presubmit successful).

[alexandre.ardhuin, 2015-03-27 07:55:57]

alexandre.ardhuin@gmail.com changed reviewers:
+ alexandre.ardhuin@gmail.com

[alexandre.ardhuin, 2015-03-27 07:56:00]

https://codereview.chromium.org/1030063004/diff/1/lib/runtime/dart/_internal.js
File lib/runtime/dart/_internal.js (right):

https://codereview.chromium.org/1030063004/diff/1/lib/runtime/dart/_internal....
lib/runtime/dart/_internal.js:1663: a.set(((x) => less = dart.notNull(x$) + 1,
x$)(less), a.get(great));
Shouldn't the parameter be `x$` instead of `x` ?

This happens in several places.

[Jennifer Messerly, 2015-03-27 14:27:22]

https://codereview.chromium.org/1030063004/diff/1/lib/runtime/dart/_internal.js
File lib/runtime/dart/_internal.js (right):

https://codereview.chromium.org/1030063004/diff/1/lib/runtime/dart/_internal....
lib/runtime/dart/_internal.js:1663: a.set(((x) => less = dart.notNull(x$) + 1,
x$)(less), a.get(great));
On 2015/03/27 07:55:59, alexandre.ardhuin wrote:
> Shouldn't the parameter be `x$` instead of `x` ?
> 
> This happens in several places.

good catch! Missed one place we were sending the raw name straight to code.
Landed a fix.