|
|
Created:
5 years, 9 months ago by Pranay Modified:
5 years, 8 months ago Reviewers:
Torne CC:
chromium-reviews, android-webview-reviews_chromium.org, anujsharma Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[android_webview] Convert VLOGs to DVLOGs
BUG=101424
Committed: https://crrev.com/c0e2da83019cd4ebb0ec17d6c211bd89d607b6e5
Cr-Commit-Position: refs/heads/master@{#325000}
Patch Set 1 #Patch Set 2 : Fixed Comments #Patch Set 3 : Added myname into Authors files #Messages
Total messages: 22 (7 generated)
PTAL
pranay.kumar@samsung.com changed reviewers: + torne@chromium.org
Ptal
VLOG(0) and DVLOG(0) are identical to LOG(INFO) and DLOG(INFO) respectively, they aren't controlled by the verbosity flag. Rather than just converting VLOG(0) to DVLOG(0) we should be changing them to a nonzero verbosity level or deleting them entirely. I have a CL in progress to check for D?VLOG(0) in presubmit checks and prevent any new instances being added :) In this particular case, these log messages are unlikely to be of much value; you can just delete them instead.
On 2015/03/26 10:47:44, Torne wrote: > VLOG(0) and DVLOG(0) are identical to LOG(INFO) and DLOG(INFO) respectively, > they aren't controlled by the verbosity flag. Rather than just converting > VLOG(0) to DVLOG(0) we should be changing them to a nonzero verbosity level or > deleting them entirely. I have a CL in progress to check for D?VLOG(0) in > presubmit checks and prevent any new instances being added :) > > In this particular case, these log messages are unlikely to be of much value; > you can just delete them instead. Sorry for delay in response, as I was on vacation. Thanks Torne for your comments, As suggested I have removed those logs. Please take a look Thanks
lgtm
On 2015/04/13 10:05:13, Torne wrote: > lgtm Thanks Torne for LGTM
The CQ bit was checked by pranay.kumar@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1030053006/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by pranay.kumar@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1030053006/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by pranay.kumar@samsung.com
The patchset sent to the CQ was uploaded after l-g-t-m from torne@chromium.org Link to the patchset: https://codereview.chromium.org/1030053006/#ps40001 (title: "Added myname into Authors files")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1030053006/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/c0e2da83019cd4ebb0ec17d6c211bd89d607b6e5 Cr-Commit-Position: refs/heads/master@{#325000}
Message was sent while issue was closed.
Have you signed the contributor license agreement? https://www.chromium.org/developers/contributing-code#TOC-Get-your-code-ready
Message was sent while issue was closed.
On 2015/04/14 05:41:03, boliu wrote: > Have you signed the contributor license agreement? > https://www.chromium.org/developers/contributing-code#TOC-Get-your-code-ready @Boliu, yes, I have signed CLA. Thanks. |