Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 1030053006: [android_webview] Convert VLOGs to DVLOGs (Closed)

Created:
5 years, 9 months ago by Pranay
Modified:
5 years, 8 months ago
Reviewers:
Torne
CC:
chromium-reviews, android-webview-reviews_chromium.org, anujsharma
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[android_webview] Convert VLOGs to DVLOGs BUG=101424 Committed: https://crrev.com/c0e2da83019cd4ebb0ec17d6c211bd89d607b6e5 Cr-Commit-Position: refs/heads/master@{#325000}

Patch Set 1 #

Patch Set 2 : Fixed Comments #

Patch Set 3 : Added myname into Authors files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M AUTHORS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M android_webview/browser/aw_browser_main_parts.cc View 1 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 22 (7 generated)
Pranay
PTAL
5 years, 9 months ago (2015-03-26 10:37:46 UTC) #1
Pranay
Ptal
5 years, 9 months ago (2015-03-26 10:39:00 UTC) #3
Torne
VLOG(0) and DVLOG(0) are identical to LOG(INFO) and DLOG(INFO) respectively, they aren't controlled by the ...
5 years, 9 months ago (2015-03-26 10:47:44 UTC) #4
Pranay
On 2015/03/26 10:47:44, Torne wrote: > VLOG(0) and DVLOG(0) are identical to LOG(INFO) and DLOG(INFO) ...
5 years, 8 months ago (2015-04-13 10:01:11 UTC) #5
Torne
lgtm
5 years, 8 months ago (2015-04-13 10:05:13 UTC) #6
Pranay
On 2015/04/13 10:05:13, Torne wrote: > lgtm Thanks Torne for LGTM
5 years, 8 months ago (2015-04-13 10:05:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1030053006/20001
5 years, 8 months ago (2015-04-13 10:06:16 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/55826)
5 years, 8 months ago (2015-04-13 10:14:16 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1030053006/20001
5 years, 8 months ago (2015-04-14 03:27:54 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/56101)
5 years, 8 months ago (2015-04-14 03:33:34 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1030053006/40001
5 years, 8 months ago (2015-04-14 04:23:26 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-14 04:48:31 UTC) #19
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/c0e2da83019cd4ebb0ec17d6c211bd89d607b6e5 Cr-Commit-Position: refs/heads/master@{#325000}
5 years, 8 months ago (2015-04-14 04:49:25 UTC) #20
boliu
Have you signed the contributor license agreement? https://www.chromium.org/developers/contributing-code#TOC-Get-your-code-ready
5 years, 8 months ago (2015-04-14 05:41:03 UTC) #21
Pranay
5 years, 8 months ago (2015-04-14 06:57:26 UTC) #22
Message was sent while issue was closed.
On 2015/04/14 05:41:03, boliu wrote:
> Have you signed the contributor license agreement?
> https://www.chromium.org/developers/contributing-code#TOC-Get-your-code-ready

@Boliu,
yes, I have signed CLA.
Thanks.

Powered by Google App Engine
This is Rietveld 408576698