Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1030023002: Remove the QuicDispatcher's explicit use of EpollServer. (Closed)

Created:
5 years, 9 months ago by Ryan Hamilton
Modified:
5 years, 9 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the QuicDispatcher's explicit use of EpollServer. To facilitate landing actual QuicServer support in Chromium using Chromium's MessageLoop and friends. Merge internal change: 89309068 R=rtenneti@chromium.org BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -38 lines) Patch
M net/tools/quic/quic_dispatcher.h View 6 chunks +8 lines, -17 lines 0 comments Download
M net/tools/quic/quic_dispatcher.cc View 4 chunks +18 lines, -11 lines 0 comments Download
M net/tools/quic/quic_dispatcher_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_server.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/quic/quic_server.cc View 2 chunks +2 lines, -1 line 0 comments Download
M net/tools/quic/quic_server_test.cc View 2 chunks +2 lines, -1 line 0 comments Download
M net/tools/quic/test_tools/mock_quic_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/test_tools/mock_quic_dispatcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/tools/quic/test_tools/packet_dropping_test_writer.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/tools/quic/test_tools/packet_dropping_test_writer.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/test_tools/quic_dispatcher_peer.h View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/test_tools/quic_dispatcher_peer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Ryan Hamilton
5 years, 9 months ago (2015-03-24 21:04:38 UTC) #1
ramant (doing other things)
5 years, 9 months ago (2015-03-24 21:28:18 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698