Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 1030013004: Cleanup dependency specification for Chromoting test isolate. (Closed)

Created:
5 years, 9 months ago by anandc
Modified:
5 years, 9 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Specify whole directory as a dependency, rather than individual files. BUG= Committed: https://crrev.com/9ac40f441976fff1cbbf8770fbf45c5f4aa2627f Cr-Commit-Position: refs/heads/master@{#322308}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -11 lines) Patch
M testing/chromoting/chromoting_integration_tests.isolate View 1 chunk +1 line, -11 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
anandc
PTAL. Thanks.
5 years, 9 months ago (2015-03-26 00:05:40 UTC) #2
Sergey Ulanov
lgtm
5 years, 9 months ago (2015-03-26 00:23:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1030013004/20001
5 years, 9 months ago (2015-03-26 00:28:59 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 9 months ago (2015-03-26 03:46:18 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 03:46:48 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9ac40f441976fff1cbbf8770fbf45c5f4aa2627f
Cr-Commit-Position: refs/heads/master@{#322308}

Powered by Google App Engine
This is Rietveld 408576698