Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: runtime/vm/service_isolate.h

Issue 1030013002: Shutdown the service isolate when shutting down the VM (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/service_isolate.h
diff --git a/runtime/vm/service_isolate.h b/runtime/vm/service_isolate.h
index 824d136de823e54d6d7794913dd834a9cccdb98f..e71027f3479f0526abee34459af52544205c5d02 100644
--- a/runtime/vm/service_isolate.h
+++ b/runtime/vm/service_isolate.h
@@ -28,11 +28,15 @@ class ServiceIsolate : public AllStatic {
static void Run();
static bool SendIsolateStartupMessage();
static bool SendIsolateShutdownMessage();
+ static void SendServiceExitMessage();
+ static void Shutdown();
protected:
static void SetServicePort(Dart_Port port);
static void SetServiceIsolate(Isolate* isolate);
static void SetLoadPort(Dart_Port port);
+ static void ConstructExitMessageAndCache(Isolate* isolate);
+ static void FinishedExiting();
static void FinishedInitializing();
static void MaybeInjectVMServiceLibrary(Isolate* isolate);
static Dart_IsolateCreateCallback create_callback() {
@@ -44,8 +48,11 @@ class ServiceIsolate : public AllStatic {
Dart_Handle url);
static Dart_IsolateCreateCallback create_callback_;
+ static uint8_t* exit_message_;
+ static intptr_t exit_message_length_;
static Monitor* monitor_;
static bool initializing_;
+ static bool shutting_down_;
static Isolate* isolate_;
static Dart_Port port_;
static Dart_Port load_port_;

Powered by Google App Engine
This is Rietveld 408576698