runtime/vm/dart.cc - Issue 1030013002: Shutdown the service isolate when shutting down the VM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/dart.cc

Issue 1030013002: Shutdown the service isolate when shutting down the VM (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/dart.cc

diff --git a/runtime/vm/dart.cc b/runtime/vm/dart.cc

index 5f09db11b0780ebff133ea425684609c5ac9b961..a6ef9594acdafb704a92de7764575500cec5cdfe 100644

--- a/runtime/vm/dart.cc

+++ b/runtime/vm/dart.cc

@@ -158,6 +158,8 @@ const char* Dart::InitOnce(Dart_IsolateCreateCallback create,

const char* Dart::Cleanup() {

+ // Shutdown the service isolate before shutting down the thread pool.

+ ServiceIsolate::Shutdown();

#if 0

// Ideally we should shutdown the VM isolate here, but the thread pool

// shutdown does not seem to ensure that all the threads have stopped

« runtime/bin/vmservice/vmservice_io.dart ('K') | « runtime/bin/vmservice/vmservice_io.dart ('k') | runtime/vm/service/constants.dart » ('j') | no next file with comments »