Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1459)

Unified Diff: runtime/bin/builtin.dart

Issue 1030013002: Shutdown the service isolate when shutting down the VM (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/bin/vmservice/server.dart » ('j') | runtime/bin/vmservice/vmservice_io.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/builtin.dart
diff --git a/runtime/bin/builtin.dart b/runtime/bin/builtin.dart
index 7e31b3c13040d771d1cdda8db1e66b299e94ecba..59338260107e067d1ca223b8823ae4877b027533 100644
--- a/runtime/bin/builtin.dart
+++ b/runtime/bin/builtin.dart
@@ -295,6 +295,7 @@ _loadDataAsyncLoadPort(int tag,
Uri resourceUri) {
var receivePort = new ReceivePort();
receivePort.first.then((dataOrError) {
+ receivePort.close();
if (dataOrError is List<int>) {
_loadScript(tag, uri, libraryUri, dataOrError);
} else {
@@ -303,6 +304,7 @@ _loadDataAsyncLoadPort(int tag,
_asyncLoadError(tag, uri, libraryUri, error);
}
}).catchError((e) {
+ receivePort.close();
// Wrap inside a LoadError unless we are already propagating a previously
// seen LoadError.
var error = (e is LoadError) ? e : new LoadError(e.toString);
« no previous file with comments | « no previous file | runtime/bin/vmservice/server.dart » ('j') | runtime/bin/vmservice/vmservice_io.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698