Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Unified Diff: runtime/bin/vmservice/server.dart

Issue 1030013002: Shutdown the service isolate when shutting down the VM (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/bin/vmservice/vmservice_io.dart » ('j') | runtime/bin/vmservice/vmservice_io.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/vmservice/server.dart
diff --git a/runtime/bin/vmservice/server.dart b/runtime/bin/vmservice/server.dart
index c6e7ce42c98ffd3941ec0058c24ad21a0b3bc25e..6612566a001909fcc9dc2422e56334f5245e0256 100644
--- a/runtime/bin/vmservice/server.dart
+++ b/runtime/bin/vmservice/server.dart
@@ -180,6 +180,13 @@ class Server {
});
}
+ close(bool force) {
zra 2015/03/24 21:53:59 Return type
Cutch 2015/03/24 23:39:07 I'm omitting 'void' return types in Dart code.
+ if (_server == null) {
+ return;
+ }
+ return _server.close(force: force);
+ }
+
Future shutdown(bool forced) {
if (_server == null) {
// Not started.
@@ -192,7 +199,7 @@ class Server {
// Shutdown HTTP server and subscription.
var ip = _server.address.address.toString();
var port = _server.port.toString();
- return _server.close(force: forced).then((_) {
+ return close(forced).then((_) {
if (_displayMessages) {
print('Observatory no longer listening on http://$ip:$port');
}
« no previous file with comments | « no previous file | runtime/bin/vmservice/vmservice_io.dart » ('j') | runtime/bin/vmservice/vmservice_io.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698