Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Side by Side Diff: runtime/vm/dart.cc

Issue 1030013002: Shutdown the service isolate when shutting down the VM (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/dart.h" 5 #include "vm/dart.h"
6 6
7 #include "vm/code_observers.h" 7 #include "vm/code_observers.h"
8 #include "vm/cpu.h" 8 #include "vm/cpu.h"
9 #include "vm/dart_api_state.h" 9 #include "vm/dart_api_state.h"
10 #include "vm/dart_entry.h" 10 #include "vm/dart_entry.h"
(...skipping 166 matching lines...) Expand 10 before | Expand all | Expand 10 after
177 // There is a planned and known asymmetry here: We exit one scope for the VM 177 // There is a planned and known asymmetry here: We exit one scope for the VM
178 // isolate to account for the scope that was entered in Dart_InitOnce. 178 // isolate to account for the scope that was entered in Dart_InitOnce.
179 Dart_ExitScope(); 179 Dart_ExitScope();
180 180
181 ShutdownIsolate(); 181 ShutdownIsolate();
182 vm_isolate_ = NULL; 182 vm_isolate_ = NULL;
183 183
184 TargetCPUFeatures::Cleanup(); 184 TargetCPUFeatures::Cleanup();
185 #endif 185 #endif
186 186
187 ServiceIsolate::Shutdown();
zra 2015/03/24 21:53:59 Make a note that this needs to happen before we tr
Cutch 2015/03/24 23:39:07 I've moved it up and left a note.
187 Profiler::Shutdown(); 188 Profiler::Shutdown();
188 CodeObservers::DeleteAll(); 189 CodeObservers::DeleteAll();
189 190
190 return NULL; 191 return NULL;
191 } 192 }
192 193
193 194
194 Isolate* Dart::CreateIsolate(const char* name_prefix) { 195 Isolate* Dart::CreateIsolate(const char* name_prefix) {
195 // Create a new isolate. 196 // Create a new isolate.
196 Isolate* isolate = Isolate::Init(name_prefix); 197 Isolate* isolate = Isolate::Init(name_prefix);
(...skipping 113 matching lines...) Expand 10 before | Expand all | Expand 10 after
310 return predefined_handles_->handles_.AllocateScopedHandle(); 311 return predefined_handles_->handles_.AllocateScopedHandle();
311 } 312 }
312 313
313 314
314 bool Dart::IsReadOnlyHandle(uword address) { 315 bool Dart::IsReadOnlyHandle(uword address) {
315 ASSERT(predefined_handles_ != NULL); 316 ASSERT(predefined_handles_ != NULL);
316 return predefined_handles_->handles_.IsValidScopedHandle(address); 317 return predefined_handles_->handles_.IsValidScopedHandle(address);
317 } 318 }
318 319
319 } // namespace dart 320 } // namespace dart
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698