Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1029983002: Upstream ios/web/ JS files (Closed)

Created:
5 years, 9 months ago by stuartmorgan
Modified:
5 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream ios/web/ JS files This upstreams all the injected JS for the web layer (but not any of the packaging bits, which will come later) BUG=464810 Committed: https://crrev.com/1ab833b209a2e2fc1e6bf2001d0bfcc5181e7bf2 Cr-Commit-Position: refs/heads/master@{#322080}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1662 lines, -0 lines) Patch
M ios/web/web_state/js/resources/base.js View 1 chunk +2 lines, -0 lines 0 comments Download
M ios/web/web_state/js/resources/common.js View 2 chunks +113 lines, -0 lines 0 comments Download
A ios/web/web_state/js/resources/console.js View 1 chunk +44 lines, -0 lines 0 comments Download
A ios/web/web_state/js/resources/core.js View 1 chunk +646 lines, -0 lines 0 comments Download
A ios/web/web_state/js/resources/core_dynamic_ui.js View 1 chunk +157 lines, -0 lines 0 comments Download
A ios/web/web_state/js/resources/core_dynamic_wk.js View 1 chunk +59 lines, -0 lines 0 comments Download
A ios/web/web_state/js/resources/dialog_overrides.js View 1 chunk +114 lines, -0 lines 0 comments Download
M ios/web/web_state/js/resources/message.js View 1 chunk +2 lines, -0 lines 0 comments Download
M ios/web/web_state/js/resources/message_dynamic_ui.js View 1 chunk +2 lines, -0 lines 0 comments Download
M ios/web/web_state/js/resources/message_dynamic_wk.js View 1 chunk +2 lines, -0 lines 0 comments Download
A ios/web/web_state/js/resources/plugin_placeholder.js View 1 chunk +199 lines, -0 lines 0 comments Download
A ios/web/web_state/js/resources/web_bundle_ui.js View 1 chunk +16 lines, -0 lines 0 comments Download
A ios/web/web_state/js/resources/web_bundle_wk.js View 1 chunk +15 lines, -0 lines 0 comments Download
A ios/web/web_state/js/resources/window_id.js View 1 chunk +31 lines, -0 lines 0 comments Download
A ios/web/web_state/js/resources/window_open_ui.js View 1 chunk +245 lines, -0 lines 0 comments Download
A ios/web/web_state/js/resources/window_open_wk.js View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
stuartmorgan
Please CQ
5 years, 9 months ago (2015-03-24 20:41:22 UTC) #2
Eugene But (OOO till 7-30)
lgtm
5 years, 9 months ago (2015-03-24 20:45:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1029983002/1
5 years, 9 months ago (2015-03-24 20:46:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-24 22:22:38 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 22:23:29 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/1ab833b209a2e2fc1e6bf2001d0bfcc5181e7bf2
Cr-Commit-Position: refs/heads/master@{#322080}

Powered by Google App Engine
This is Rietveld 408576698