Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1029973003: land some real hashtags (Closed)

Created:
5 years, 9 months ago by mtklein_C
Modified:
5 years, 9 months ago
Reviewers:
rmistry, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M HASHTAGS View 1 chunk +5 lines, -2 lines 1 comment Download

Messages

Total messages: 8 (2 generated)
mtklein_C
5 years, 9 months ago (2015-03-25 19:57:25 UTC) #2
rmistry
LGTM https://codereview.chromium.org/1029973003/diff/1/HASHTAGS File HASHTAGS (right): https://codereview.chromium.org/1029973003/diff/1/HASHTAGS#newcode17 HASHTAGS:17: n7,CQ_INCLUDE_TRYBOTS=client.skia.android:Test-Android-Nexus7-Tegra3-Arm7-Debug-Trybot n7 is Debug and n9 is Release, ...
5 years, 9 months ago (2015-03-25 19:59:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1029973003/1
5 years, 9 months ago (2015-03-25 19:59:53 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-03-25 19:59:54 UTC) #6
mtklein
On 2015/03/25 19:59:49, rmistry wrote: > LGTM > > https://codereview.chromium.org/1029973003/diff/1/HASHTAGS > File HASHTAGS (right): > ...
5 years, 9 months ago (2015-03-25 20:01:11 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 20:08:46 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c4a933be63c71e92193792c020e6263b6ccabc89

Powered by Google App Engine
This is Rietveld 408576698