Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Issue 1029933003: Use the worker task runner instead of the main audio thread. (Closed)

Created:
5 years, 9 months ago by DaleCurtis
Modified:
5 years, 9 months ago
Reviewers:
nasko
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use the worker task runner instead of the main audio thread. On OSX the main audio thread is the UI thread due to limitations in the CoreAudio API. Since we're making effectively read only calls sending the audio hardware config from the worker task runner should be fine. We already do this in several other places for device enumeration (since it's way to slow on UI thread). BUG=469737 TEST=none Committed: https://crrev.com/06def69114b5ecae4f0ee0aa875181568fe7902c Cr-Commit-Position: refs/heads/master@{#322292}

Patch Set 1 #

Patch Set 2 : Fix thread check. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
DaleCurtis
5 years, 9 months ago (2015-03-24 20:44:57 UTC) #2
nasko
LGTM
5 years, 9 months ago (2015-03-24 23:33:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1029933003/1
5 years, 9 months ago (2015-03-24 23:36:45 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/1103)
5 years, 9 months ago (2015-03-25 02:45:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1029933003/1
5 years, 9 months ago (2015-03-25 17:34:43 UTC) #9
DaleCurtis
Whoops, had the wrong thread check after changing the loop posted to. Fixed.
5 years, 9 months ago (2015-03-25 22:32:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1029933003/20001
5 years, 9 months ago (2015-03-25 22:33:20 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-26 01:33:42 UTC) #14
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 01:34:25 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/06def69114b5ecae4f0ee0aa875181568fe7902c
Cr-Commit-Position: refs/heads/master@{#322292}

Powered by Google App Engine
This is Rietveld 408576698