Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 102993008: Remove some of the dependencies from modules/ in core/ (Closed)

Created:
7 years ago by lgombos
Modified:
7 years ago
CC:
blink-reviews, tommyw+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove some of the dependencies from modules/ in core/ and update the DEPS file. core/ should not depend on modules/ at all, but there are a number of pieces of code that do. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163389

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -12 lines) Patch
M Source/core/DEPS View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/core/page/ChromeClient.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/platform/chromium/support/WebSpeechSynthesisVoice.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/platform/mediastream/MediaStreamCenter.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
lgombos
Trivial change. Needs a rubber stamp.
7 years ago (2013-12-09 01:51:22 UTC) #1
Nico
lgtm
7 years ago (2013-12-09 02:03:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/102993008/1
7 years ago (2013-12-09 02:18:15 UTC) #3
eseidel
Love it. Keep em comin.
7 years ago (2013-12-09 02:23:48 UTC) #4
commit-bot: I haz the power
7 years ago (2013-12-09 03:21:15 UTC) #5
Message was sent while issue was closed.
Change committed as 163389

Powered by Google App Engine
This is Rietveld 408576698