Issue 102993006: Remove C++11 specific version of SafeSNPrintf()

Issue 102993006: Remove C++11 specific version of SafeSNPrintf() (Closed)

Created:
7 years ago by Inactive

Modified:
7 years ago

Reviewers:
Nico, Markus (顧孟勤)

CC:
chromium-reviews, erikwright+watch_chromium.org, jshin+watch_chromium.org, jln (very slow on Chromium)

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Remove C++11 specific version of SafeSNPrintf() Remove C++11 specific version of SafeSNPrintf() as we don't really use C++11 yet and adding code like this adds a maintenance cost. For example, the code in question does not build with gcc 4.7 despite C++11 support being enabled. R=Nico BUG=233330 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239227

Patch Set 1 #

Total comments: 3

Patch Set 2 : Remove pre-c++11 related comments #

Patch Set 3 : Update unit test as well #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -37 lines)			Patch
	M	base/strings/safe_sprintf.h	View	1	3 chunks	+1 line, -25 lines	0 comments	Download
	M	base/strings/safe_sprintf_unittest.cc	View	1 2	1 chunk	+0 lines, -12 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Nico

lgtm https://codereview.chromium.org/102993006/diff/1/base/strings/safe_sprintf.h File base/strings/safe_sprintf.h (right): https://codereview.chromium.org/102993006/diff/1/base/strings/safe_sprintf.h#newcode107 base/strings/safe_sprintf.h:107: // The pre-C++11 version cannot handle more than ...

7 years ago (2013-12-05 21:32:17 UTC) #2

Inactive

https://codereview.chromium.org/102993006/diff/1/base/strings/safe_sprintf.h File base/strings/safe_sprintf.h (right): https://codereview.chromium.org/102993006/diff/1/base/strings/safe_sprintf.h#newcode107 base/strings/safe_sprintf.h:107: // The pre-C++11 version cannot handle more than ten ...

7 years ago (2013-12-05 21:36:39 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/102993006/40001

7 years ago (2013-12-06 14:13:45 UTC) #4

Message was sent while issue was closed.

Change committed as 239227

Expand Messages | Collapse Messages