chrome/utility/DEPS - Issue 102993002: Implement Networking Private API VerifyAndEncryptCredentials method

Side by Side Diff: chrome/utility/DEPS

Issue 102993002: Implement Networking Private API VerifyAndEncryptCredentials method (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Implemented NetworkingPrivateCredentialsGetterMac. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/extensions/api/networking_private/networking_private_service_client.h ('K') | « chrome/common/chrome_utility_messages.h ('k') | chrome/utility/chrome_content_utility_client.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 include_rules = [	1 include_rules = [

	2 "+chrome/browser/extensions/api/networking_private",
	tbarzic 2014/02/07 19:25:00 Hm, I'm not sure if adding dependency on chrome/br Hm, I'm not sure if adding dependency on chrome/browser/ this is ok or not. I guess you could avoid this by moving chrome/browser/extensions/api/networking_private/networking_private_crypto somewhere already accessible from chrome/utility. mef 2014/02/07 19:53:31 I agree, but where? The most reasonable seems to b Show quoted text On 2014/02/07 19:25:00, tbarzic wrote: > Hm, I'm not sure if adding dependency on chrome/browser/ this is ok or not. > I guess you could avoid this by moving > chrome/browser/extensions/api/networking_private/networking_private_crypto > somewhere already accessible from chrome/utility. I agree, but where? The most reasonable seems to be "extensions/common", but even that doesn't seem to be right. OTOH chrome/utility/importer has its own DEPS, so maybe I should add chrome/utility/networking_private and add DEPS there? tbarzic 2014/02/07 22:43:02 I wouldn't move this to a new dir just for a sake Show quoted text On 2014/02/07 19:53:31, mef wrote: > On 2014/02/07 19:25:00, tbarzic wrote: > > Hm, I'm not sure if adding dependency on chrome/browser/ this is ok or not. > > I guess you could avoid this by moving > > chrome/browser/extensions/api/networking_private/networking_private_crypto > > somewhere already accessible from chrome/utility. > > I agree, but where? The most reasonable seems to be "extensions/common", but > even that doesn't seem to be right. OTOH chrome/utility/importer has its own > DEPS, so maybe I should add chrome/utility/networking_private and add DEPS > there? I wouldn't move this to a new dir just for a sake of adding a new dep. If adding a dependency to chrome/browser here is wrong, it would be wrong in chrome/utility/foo :) Though, it may be better to defer this question to jam@. I'm not sure what would be the best alternative home for networking_private_crypto. Somewhere in extension sounds OK to me, but there may be people with stronger opinion against this. Other places I'd consider are net/ or components/wifi (though this would probably require some renaming/generalization). mef 2014/02/11 23:20:05 Ack. I really need an advise from jam@ at this poi Show quoted text On 2014/02/07 22:43:02, tbarzic wrote: > On 2014/02/07 19:53:31, mef wrote: > > On 2014/02/07 19:25:00, tbarzic wrote: > > > Hm, I'm not sure if adding dependency on chrome/browser/ this is ok or not. > > > I guess you could avoid this by moving > > > chrome/browser/extensions/api/networking_private/networking_private_crypto > > > somewhere already accessible from chrome/utility. > > > > I agree, but where? The most reasonable seems to be "extensions/common", but > > even that doesn't seem to be right. OTOH chrome/utility/importer has its own > > DEPS, so maybe I should add chrome/utility/networking_private and add DEPS > > there? > > I wouldn't move this to a new dir just for a sake of adding a new dep. If adding > a dependency to chrome/browser here is wrong, it would be wrong in > chrome/utility/foo :) > Though, it may be better to defer this question to jam@. > > I'm not sure what would be the best alternative home for > networking_private_crypto. Somewhere in extension sounds OK to me, but there may > be people with stronger opinion against this. > Other places I'd consider are net/ or components/wifi (though this would > probably require some renaming/generalization). Ack. I really need an advise from jam@ at this point.
2 "+content/public/child",	3 "+content/public/child",

3 "+content/public/utility",	4 "+content/public/utility",

	5 "+components/wifi",

4 "+extensions/common",	6 "+extensions/common",

5	7

6 # For generated headers.	8 # For generated headers.

7 "+grit",	9 "+grit",

8	10

9 "+skia/ext",	11 "+skia/ext",

10 "+media",	12 "+media",

11 ]	13 ]

OLD	NEW