Implement Networking Private API VerifyAndEncryptCredentials method

chrome/utility/chrome_content_utility_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/utility/chrome_content_utility_client.h"
 
 #include "base/base64.h"
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/file_util.h"
@@ skipping 29 matching lines @@
 #include "third_party/skia/include/core/SkBitmap.h"
 #include "third_party/zlib/google/zip.h"
 #include "ui/base/ui_base_switches.h"
 #include "ui/gfx/codec/jpeg_codec.h"
 #include "ui/gfx/rect.h"
 #include "ui/gfx/size.h"
 
 #if defined(OS_WIN)
 #include "base/win/iat_patch_function.h"
 #include "base/win/scoped_handle.h"
+#include "chrome/common/extensions/api/networking_private/networking_private_crypto.h"
 #include "chrome/utility/media_galleries/itunes_pref_parser_win.h"
+#include "components/wifi/wifi_service.h"
 #include "printing/emf_win.h"
 #include "ui/gfx/gdi_util.h"
 #endif  // defined(OS_WIN)
 
 #if defined(OS_MACOSX)
 #include "chrome/utility/media_galleries/iphoto_library_parser.h"
 #endif  // defined(OS_MACOSX)
 
 #if defined(OS_WIN) || defined(OS_MACOSX)
 #include "chrome/utility/media_galleries/iapps_xml_utils.h"
@@ skipping 332 matching lines @@
 
 #if defined(OS_WIN) || defined(OS_MACOSX)
     IPC_MESSAGE_HANDLER(ChromeUtilityMsg_ParseITunesLibraryXmlFile,
                         OnParseITunesLibraryXmlFile)
     IPC_MESSAGE_HANDLER(ChromeUtilityMsg_ParsePicasaPMPDatabase,
                         OnParsePicasaPMPDatabase)
     IPC_MESSAGE_HANDLER(ChromeUtilityMsg_IndexPicasaAlbumsContents,
                         OnIndexPicasaAlbumsContents)
 #endif  // defined(OS_WIN) || defined(OS_MACOSX)
 
+#if defined(OS_WIN)
+    IPC_MESSAGE_HANDLER(ChromeUtilityHostMsg_GetAndEncryptWiFiCredentials,
+                        OnGetAndEncryptWiFiCredentials)
+#endif  // defined(OS_WIN)
+
     IPC_MESSAGE_UNHANDLED(handled = false)
   IPC_END_MESSAGE_MAP()
 
   for (Handlers::iterator it = handlers_.begin();
        !handled && it != handlers_.end(); ++it) {
     handled = (*it)->OnMessageReceived(message);
   }
 
   return handled;
 }
@@ skipping 482 matching lines @@
     const std::vector<picasa::FolderINIContents>& folders_inis) {
   picasa::PicasaAlbumsIndexer indexer(album_uids);
   indexer.ParseFolderINI(folders_inis);
 
   Send(new ChromeUtilityHostMsg_IndexPicasaAlbumsContents_Finished(
       indexer.albums_images()));
   ReleaseProcessIfNeeded();
 }
 #endif  // defined(OS_WIN) || defined(OS_MACOSX)
 
+#if defined(OS_WIN)
+void ChromeContentUtilityClient::OnGetAndEncryptWiFiCredentials(
+    const std::string& network_guid,

[palmer, 2014/03/05 00:20:54]

Can we use the GUID type in base/guid.h instead?

If not, for some reason:

Since we call this thing a "GUID", we should check that it actually meets the
lexical definition of a GUID (including enforcing the expected size).

Or perhaps wifi_service->GetKeyFromSystem does that? If so, document that fact
with a comment so that people don't wonder.

[mef, 2014/03/05 01:21:40]

It is (admittedly confusingly) called |network_guid| to match naming defined by
chromeos implementation. 
I think stevejb@ can provide some background. In windows and mac implementation
it equals to network ssid.

+    const std::vector<uint8>& public_key) {
+  scoped_ptr<wifi::WiFiService> wifi_service(wifi::WiFiService::Create());
+  wifi_service->Initialize(NULL);
+
+  std::string key_data;
+  std::string error;
+  wifi_service->GetKeyFromSystem(network_guid, &key_data, &error);

[palmer, 2014/03/05 00:20:54]

Ah, I see. This function expects strings. Is it possible to refactor that later
(not in this CL)? E.g the |network_guid| should be a GUID, the |key_data| should
be a byte vector, and you don't need |error| because the callee only ever sets
it to |kWiFiServiceError|, and checking for an error string to be empty is a bit
odd (I'd just use a bool).

[mef, 2014/03/05 01:21:40]

Strictly speaking WiFiService is a component that could be used by other
modules. 
Returning |error| string matches other interface functions, so I'd rather keep
it.
I agree that in this particular case |bool| is sufficient, but it is not always
the case.

+
+  std::vector<uint8> ciphertext;
+  bool success = error.empty() && !key_data.empty();
+  if (success) {
+    NetworkingPrivateCrypto crypto;
+    success = crypto.EncryptByteString(public_key, key_data, &ciphertext);
+  }
+
+  Send(new ChromeUtilityHostMsg_GotEncryptedWiFiCredentials(ciphertext,
+                                                            success));
+}
+#endif  // defined(OS_WIN)
+
 }  // namespace chrome