chrome/common/chrome_utility_messages.h - Issue 102993002: Implement Networking Private API VerifyAndEncryptCredentials method

Side by Side Diff: chrome/common/chrome_utility_messages.h

Issue 102993002: Implement Networking Private API VerifyAndEncryptCredentials method (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Sync to r254157 Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/chrome_tests_unit.gypi ('k') | chrome/common/extensions/api/networking_private/networking_private_crypto.h » ('j') | chrome/common/extensions/api/networking_private/networking_private_crypto.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Multiply-included message file, so no include guard.	5 // Multiply-included message file, so no include guard.

6	6

7 #include <string>	7 #include <string>

8 #include <vector>	8 #include <vector>

9	9

10 #include "base/basictypes.h"	10 #include "base/basictypes.h"

(...skipping 452 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
463 // Reply when a write or verify operation has been fully cancelled.	463 // Reply when a write or verify operation has been fully cancelled.

464 IPC_MESSAGE_CONTROL0(ChromeUtilityHostMsg_ImageWriter_Cancelled)	464 IPC_MESSAGE_CONTROL0(ChromeUtilityHostMsg_ImageWriter_Cancelled)

465	465

466 // Reply when a write or verify operation fails to complete.	466 // Reply when a write or verify operation fails to complete.

467 IPC_MESSAGE_CONTROL1(ChromeUtilityHostMsg_ImageWriter_Failed,	467 IPC_MESSAGE_CONTROL1(ChromeUtilityHostMsg_ImageWriter_Failed,

468 std::string /* message */)	468 std::string /* message */)

469	469

470 // Periodic status update about the progress of an operation.	470 // Periodic status update about the progress of an operation.

471 IPC_MESSAGE_CONTROL1(ChromeUtilityHostMsg_ImageWriter_Progress,	471 IPC_MESSAGE_CONTROL1(ChromeUtilityHostMsg_ImageWriter_Progress,

472 int64 /* number of bytes processed */)	472 int64 /* number of bytes processed */)

	473

	474 #if defined(OS_WIN)

	475 // Get plain-text WiFi credentials from the system (requires UAC privilege

	476 // elevation) and encrypt it with \|public_key\|.

	477 IPC_MESSAGE_CONTROL2(ChromeUtilityHostMsg_GetAndEncryptWiFiCredentials,

	478 std::string /* ssid */,

	479 std::string /* public_key */)
	palmer 2014/03/03 22:17:42 vector<uint8> would be a better type for a key; be vector<uint8> would be a better type for a key; better yet, some particular key type. mef 2014/03/04 21:57:03 Done. Show quoted text On 2014/03/03 22:17:42, Chromium Palmer wrote: > vector<uint8> would be a better type for a key; better yet, some particular key > type. Done.
	480

	481 // Reply after gettng WiFi credentials from the system and encrypting it with
	Jorge Lucangeli Obes 2014/03/03 23:31:39 nits: typo in "getting", "encrypting them" for ver nits: typo in "getting", "encrypting them" for verb-object agreement. mef 2014/03/04 21:57:03 Done. Show quoted text On 2014/03/03 23:31:39, Jorge Lucangeli Obes wrote: > nits: typo in "getting", "encrypting them" for verb-object agreement. Done.
	482 // caller's public key. \|error\| is not empty if error occured..
	palmer 2014/03/03 22:17:42 Nit: Just 1 ".". Nit: Just 1 ".". mef 2014/03/04 21:57:03 Done. Show quoted text On 2014/03/03 22:17:42, Chromium Palmer wrote: > Nit: Just 1 ".". Done.
	483 IPC_MESSAGE_CONTROL2(ChromeUtilityHostMsg_GotEncryptedWiFiCredentials,

	484 std::string /* encrypted_key_data */,
	palmer 2014/03/03 22:17:42 vector<uint8> is a better type for encrypted data. vector<uint8> is a better type for encrypted data. mef 2014/03/04 21:57:03 Done. Show quoted text On 2014/03/03 22:17:42, Chromium Palmer wrote: > vector<uint8> is a better type for encrypted data. Done.
	485 std::string /* error */)
	palmer 2014/03/03 22:17:42 How many possible errors are there? An enumerated How many possible errors are there? An enumerated constant type would be better here. (Then let the privileged recipient stringify it according to its policy.) mef 2014/03/04 21:57:03 Done. Show quoted text On 2014/03/03 22:17:42, Chromium Palmer wrote: > How many possible errors are there? An enumerated constant type would be better > here. (Then let the privileged recipient stringify it according to its policy.) Done.
	486 #endif // defined(OS_WIN)

OLD	NEW