Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 1029843002: [turbofan] Address minor TODOs in simplified lowering. (Closed)

Created:
5 years, 9 months ago by titzer
Modified:
5 years, 9 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Address minor TODOs in simplified lowering. R=jarin@chromium.org BUG= Committed: https://crrev.com/6e75e34dd34fa9968c975537b5fbac7a36b24aa9 Cr-Commit-Position: refs/heads/master@{#27413}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -27 lines) Patch
M src/compiler/simplified-lowering.cc View 2 chunks +16 lines, -27 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
titzer
5 years, 9 months ago (2015-03-24 13:58:10 UTC) #1
Jarin
lgtm
5 years, 9 months ago (2015-03-24 14:28:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1029843002/1
5 years, 9 months ago (2015-03-24 14:35:45 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-24 15:01:19 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 15:01:27 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6e75e34dd34fa9968c975537b5fbac7a36b24aa9
Cr-Commit-Position: refs/heads/master@{#27413}

Powered by Google App Engine
This is Rietveld 408576698