Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1029823002: V8 Sampling Profiler: Support sampling on Windows. (Closed)

Created:
5 years, 9 months ago by alph
Modified:
5 years, 9 months ago
Reviewers:
yurys
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, yurys, darin-cc_chromium.org, devtools-reviews_chromium.org, mkwst+moarreviews-renderer_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

V8 Sampling Profiler: Support sampling on Windows. BUG=406277 Committed: https://crrev.com/99aa9e5075911022c7de64c1c699368681e9067c Cr-Commit-Position: refs/heads/master@{#321999}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -50 lines) Patch
M content/renderer/devtools/v8_sampling_profiler.cc View 7 chunks +52 lines, -37 lines 2 comments Download
M content/renderer/devtools/v8_sampling_profiler_browsertest.cc View 2 chunks +3 lines, -13 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
alph
5 years, 9 months ago (2015-03-24 13:00:43 UTC) #2
yurys
lgtm https://codereview.chromium.org/1029823002/diff/1/content/renderer/devtools/v8_sampling_profiler.cc File content/renderer/devtools/v8_sampling_profiler.cc (right): https://codereview.chromium.org/1029823002/diff/1/content/renderer/devtools/v8_sampling_profiler.cc#newcode19 content/renderer/devtools/v8_sampling_profiler.cc:19: #include "base/win/scoped_handle.h" Please minimize number of dependencies on ...
5 years, 9 months ago (2015-03-24 14:15:25 UTC) #3
alph
https://codereview.chromium.org/1029823002/diff/1/content/renderer/devtools/v8_sampling_profiler.cc File content/renderer/devtools/v8_sampling_profiler.cc (right): https://codereview.chromium.org/1029823002/diff/1/content/renderer/devtools/v8_sampling_profiler.cc#newcode19 content/renderer/devtools/v8_sampling_profiler.cc:19: #include "base/win/scoped_handle.h" On 2015/03/24 14:15:25, yurys wrote: > Please ...
5 years, 9 months ago (2015-03-24 14:17:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1029823002/1
5 years, 9 months ago (2015-03-24 14:17:35 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-24 15:13:38 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 15:14:37 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/99aa9e5075911022c7de64c1c699368681e9067c
Cr-Commit-Position: refs/heads/master@{#321999}

Powered by Google App Engine
This is Rietveld 408576698