Add chrome.fileSystem.GetVolumeList().

Add chrome.fileSystem.GetVolumeList().

This CL adds a method to list available volumes. It's available only to kiosk
apps running in kiosk session and to some whitelited component apps/extensions.

TBR=fukino@chromium.org  # chrome_extensions.js reviewed at cr/90486340.
TEST=browser_tests: *KioskTest*GetVolumeList*,
     *FileSystemApiTestForRequestFileSystem*GetVolumeList*
BUG=440674
Committed: https://crrev.com/8950a1dd2458b1fb0c34a60d2217a64561b47b19
Cr-Commit-Position: refs/heads/master@{#324040}

[mtomasz, 2015-03-25 09:00:35]

mtomasz@chromium.org changed reviewers:
+ benwells@chromium.org, isherman@chromium.org, xiyuan@chromium.org

[mtomasz, 2015-03-25 09:00:35]

@xiyuan, @benwells, @isherman: PTAL as below. Thanks.

xiyuan:
  chrome/browser/chromeos/login/kiosk_browsertest.cc
  and related files to that test
benwells:
  chrome/common/extensions/api/file_system.idl
  chrome/common/extensions/permissions/chrome_api_permissions.cc
  chrome/common/extensions/permissions/permission_set_unittest.cc
  extensions/common/permissions/api_permission.h
isherman:
  extensions/browser/extension_function_histogram_value.h
  tools/metrics/histograms/histograms.xml

[xiyuan, 2015-03-25 16:49:30]

kiosk_browsertest.cc and kiosk test files LGTM

[Ilya Sherman, 2015-03-25 20:33:59]

histograms.xml lgtm

[mtomasz, 2015-04-02 08:37:09]

@benwells: Ready to review. PTAL. Thanks.

[benwells, 2015-04-07 05:43:14]

lgtm with nits.

https://codereview.chromium.org/1029803004/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/api/file_system/file_system_api.cc (right):

https://codereview.chromium.org/1029803004/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/file_system/file_system_api.cc:1386: //
Additionally whitelisted component extensions and apps.
Nit: this last sentence isn't really a sentence (no verb).

https://codereview.chromium.org/1029803004/diff/40001/chrome/common/extension...
File chrome/common/extensions/api/file_system.idl (right):

https://codereview.chromium.org/1029803004/diff/40001/chrome/common/extension...
chrome/common/extensions/api/file_system.idl:135: [nodoc] callback
GetVolumeListCallback = void(optional Volume[] volumes);
Nit: should  this be optional? I think if the call succeeds (i.e. no error)
there should be a list so you can drop optional. I could be wrong abotu that
though.

https://codereview.chromium.org/1029803004/diff/40001/chrome/common/extension...
chrome/common/extensions/api/file_system.idl:188: // is required. permission in
the manifest. Available to kiosk apps running
Nit: I think you want to delete ' permission in the manifest.'

[mtomasz, 2015-04-07 07:35:35]

I moved the delegate to function body, as ChromeDetails::GetProfile() is NULL at
the moment of creating extension function, so I can't initialize the delegate in
the constructor.

https://codereview.chromium.org/1029803004/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/api/file_system/file_system_api.cc (right):

https://codereview.chromium.org/1029803004/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/file_system/file_system_api.cc:1386: //
Additionally whitelisted component extensions and apps.
On 2015/04/07 05:43:13, benwells wrote:
> Nit: this last sentence isn't really a sentence (no verb).

Done.

https://codereview.chromium.org/1029803004/diff/40001/chrome/common/extension...
File chrome/common/extensions/api/file_system.idl (right):

https://codereview.chromium.org/1029803004/diff/40001/chrome/common/extension...
chrome/common/extensions/api/file_system.idl:135: [nodoc] callback
GetVolumeListCallback = void(optional Volume[] volumes);
On 2015/04/07 05:43:13, benwells wrote:
> Nit: should  this be optional? I think if the call succeeds (i.e. no error)
> there should be a list so you can drop optional. I could be wrong abotu that
> though.

Good point. Done.

https://codereview.chromium.org/1029803004/diff/40001/chrome/common/extension...
chrome/common/extensions/api/file_system.idl:188: // is required. permission in
the manifest. Available to kiosk apps running
On 2015/04/07 05:43:13, benwells wrote:
> Nit: I think you want to delete ' permission in the manifest.'

Done.

[mtomasz, 2015-04-07 07:40:04]

mtomasz@chromium.org changed reviewers:
+ fukino@chromium.org

[mtomasz, 2015-04-07 07:40:32]

@fukino: TBR. PTAL at chrome_extensions.js. It's reviewed separately at
cr/90486340.

[benwells, 2015-04-07 07:42:03]

slgtm

[mtomasz, 2015-04-07 07:57:44]

The CQ bit was checked by mtomasz@chromium.org

[mtomasz, 2015-04-07 07:57:45]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org,
isherman@chromium.org, benwells@chromium.org
Link to the patchset: https://codereview.chromium.org/1029803004/#ps60001
(title: "Fixed IDL   moved delegate from member to function body.")

[commit-bot: I haz the power, 2015-04-07 07:58:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1029803004/60001

[mtomasz, 2015-04-07 07:58:31]

The CQ bit was unchecked by mtomasz@chromium.org

[mtomasz, 2015-04-07 13:29:51]

The CQ bit was checked by mtomasz@chromium.org

[mtomasz, 2015-04-07 13:29:52]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org,
benwells@chromium.org, isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/1029803004/#ps80001
(title: "Fixed chrome_extensions.js.")

[commit-bot: I haz the power, 2015-04-07 13:30:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1029803004/80001

[commit-bot: I haz the power, 2015-04-07 14:52:26]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-04-07 14:53:24]

Patchset 5 (id:??) landed as
https://crrev.com/8950a1dd2458b1fb0c34a60d2217a64561b47b19
Cr-Commit-Position: refs/heads/master@{#324040}