Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Unified Diff: media/blink/buffered_resource_loader_unittest.cc

Issue 1029763002: Introduce CancelUponDeferral() to buffered media loaders. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/blink/buffered_resource_loader.cc ('k') | media/blink/media_blink.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/blink/buffered_resource_loader_unittest.cc
diff --git a/media/blink/buffered_resource_loader_unittest.cc b/media/blink/buffered_resource_loader_unittest.cc
index 3e7eaa8a8858d5c0cd3f191397e0be17fba1528e..f046d607c161757a871b12bede270dd2e5db20fc 100644
--- a/media/blink/buffered_resource_loader_unittest.cc
+++ b/media/blink/buffered_resource_loader_unittest.cc
@@ -282,6 +282,8 @@ class BufferedResourceLoaderTest : public testing::Test {
EXPECT_LE(loader_->buffer_.backward_capacity(), kMaxBufferCapacity);
}
+ bool HasActiveLoader() { return loader_->active_loader_; }
+
MOCK_METHOD1(StartCallback, void(BufferedResourceLoader::Status));
MOCK_METHOD2(ReadCallback, void(BufferedResourceLoader::Status, int));
MOCK_METHOD1(LoadingCallback, void(BufferedResourceLoader::LoadingState));
@@ -1128,4 +1130,30 @@ TEST(BufferedResourceLoaderStandaloneTest, ParseContentRange) {
kPositionNotSpecified);
}
+// Tests the data buffering logic of ReadThenDefer strategy.
+TEST_F(BufferedResourceLoaderTest, CancelAfterDeferral) {
+ Initialize(kHttpUrl, 10, 99);
+ SetLoaderBuffer(10, 20);
+ loader_->UpdateDeferStrategy(BufferedResourceLoader::kReadThenDefer);
+ loader_->CancelUponDeferral();
+ Start();
+ PartialResponse(10, 99, 100);
+
+ uint8 buffer[10];
+
+ // Make an outstanding read request.
+ ReadLoader(10, 10, buffer);
+
+ // Receive almost enough data to cover, shouldn't defer.
+ WriteLoader(10, 9);
+ EXPECT_TRUE(HasActiveLoader());
+
+ // As soon as we have received enough data to fulfill the read, defer.
+ EXPECT_CALL(*this, LoadingCallback(BufferedResourceLoader::kLoadingDeferred));
+ EXPECT_CALL(*this, ReadCallback(BufferedResourceLoader::kOk, 10));
+ WriteLoader(19, 1);
+ VerifyBuffer(buffer, 10, 10);
+ EXPECT_FALSE(HasActiveLoader());
+}
+
} // namespace media
« no previous file with comments | « media/blink/buffered_resource_loader.cc ('k') | media/blink/media_blink.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698