Plumbs through android supplying multipe touch points

Plumbs through android supplying multipe touch points

Makes sky and conversions honor pointer values correctly.

R=abarth@chromium.org, erg@chromium.org, qsr@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/6aadda5ff4513d99c21d83367d99964beab2c2f4

[sky, 2015-03-23 23:28:25]

abarty: sky
qsr: android stuff (including services/native_viewport/BUILD.gn)
erg: the rest

[Elliot Glaysher, 2015-03-23 23:33:05]

lgtm

[abarth-chromium, 2015-03-24 07:51:10]

sky LGTM

[qsr, 2015-03-24 08:20:22]

https://codereview.chromium.org/1029753002/diff/20001/services/native_viewpor...
File services/native_viewport/native_viewport_impl.cc (right):

https://codereview.chromium.org/1029753002/diff/20001/services/native_viewpor...
services/native_viewport/native_viewport_impl.cc:132:
base::Owned(id_wrapper.release()));
Do you expect that this callback can be called multiple time? If not, could you
make AckEvent takes a scoped_ptr?

https://codereview.chromium.org/1029753002/diff/20001/services/native_viewpor...
File services/native_viewport/native_viewport_impl.h (right):

https://codereview.chromium.org/1029753002/diff/20001/services/native_viewpor...
services/native_viewport/native_viewport_impl.h:67: int32 id;
I am missing something, but why do you need this object? Can't you just pass
ints? Or are you planning to need more data in the future?

https://codereview.chromium.org/1029753002/diff/20001/services/native_viewpor...
File services/native_viewport/platform_viewport_android.cc (right):

https://codereview.chromium.org/1029753002/diff/20001/services/native_viewpor...
services/native_viewport/platform_viewport_android.cc:11: #include
"jni/MotionEvent_jni.h"
I'm completely missing why you need this. You do not seem to use anything from
this header but the RegisterNativesImpl that is a no-op.

Can you explain why you want to access this?

[sky, 2015-03-24 13:18:22]

https://codereview.chromium.org/1029753002/diff/20001/services/native_viewpor...
File services/native_viewport/native_viewport_impl.cc (right):

https://codereview.chromium.org/1029753002/diff/20001/services/native_viewpor...
services/native_viewport/native_viewport_impl.cc:132:
base::Owned(id_wrapper.release()));
On 2015/03/24 08:20:22, qsr (OoO until Apr 1) wrote:
> Do you expect that this callback can be called multiple time? If not, could
you
> make AckEvent takes a scoped_ptr?

Done.

https://codereview.chromium.org/1029753002/diff/20001/services/native_viewpor...
File services/native_viewport/native_viewport_impl.h (right):

https://codereview.chromium.org/1029753002/diff/20001/services/native_viewpor...
services/native_viewport/native_viewport_impl.h:67: int32 id;
On 2015/03/24 08:20:22, qsr (OoO until Apr 1) wrote:
> I am missing something, but why do you need this object? Can't you just pass
> ints? Or are you planning to need more data in the future?

I did this as I thought it a bit mysterious to take an int*. It isn't clear if
it's an array, or just one. But I changed it.

https://codereview.chromium.org/1029753002/diff/20001/services/native_viewpor...
File services/native_viewport/platform_viewport_android.cc (right):

https://codereview.chromium.org/1029753002/diff/20001/services/native_viewpor...
services/native_viewport/platform_viewport_android.cc:11: #include
"jni/MotionEvent_jni.h"
On 2015/03/24 08:20:22, qsr (OoO until Apr 1) wrote:
> I'm completely missing why you need this. You do not seem to use anything from
> this header but the RegisterNativesImpl that is a no-op.
> 
> Can you explain why you want to access this?

Ya, sorry, an early version had me calling into the event and I forgot to remove
this. Done.

[qsr, 2015-03-24 13:23:51]

lgtm

[sky, 2015-03-24 16:13:20]

Committed patchset #4 (id:50001) manually as
6aadda5ff4513d99c21d83367d99964beab2c2f4 (presubmit successful).