Issue 102973008: Removing GetDefaultProfile from CustomizationDocument

Issue 102973008: Removing GetDefaultProfile from CustomizationDocument (Closed)

Created:
7 years ago by Mr4D (OOO till 08-26)

Modified:
6 years, 11 months ago

Reviewers:
Dmitry Polukhin, Daniel Erat

CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Removing GetDefaultProfile from CustomizationDocument BUG=322682 TEST=covered by existing unit tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243626

Patch Set 2 : Removed unused header file #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	chrome/browser/chromeos/customization_document.cc	View	1	2 chunks	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Dmitry Polukhin

lgtm https://codereview.chromium.org/102973008/diff/1/chrome/browser/chromeos/customization_document.cc File chrome/browser/chromeos/customization_document.cc (right): https://codereview.chromium.org/102973008/diff/1/chrome/browser/chromeos/customization_document.cc#newcode20 chrome/browser/chromeos/customization_document.cc:20: #include "chrome/browser/profiles/profile_manager.h" I think we don't need this ...

7 years ago (2013-12-20 20:50:15 UTC) #2

Daniel Erat

(i've never heard of this file, so i'll let dmitry's review stand)

7 years ago (2013-12-20 20:51:45 UTC) #3

Mr4D (OOO till 08-26)

Removed header file! Please have another look! https://codereview.chromium.org/102973008/diff/1/chrome/browser/chromeos/customization_document.cc File chrome/browser/chromeos/customization_document.cc (right): https://codereview.chromium.org/102973008/diff/1/chrome/browser/chromeos/customization_document.cc#newcode20 chrome/browser/chromeos/customization_document.cc:20: #include "chrome/browser/profiles/profile_manager.h" ...

7 years ago (2013-12-20 22:57:20 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/102973008/270001

6 years, 11 months ago (2014-01-08 16:56:44 UTC) #6

Message was sent while issue was closed.

Change committed as 243626

Expand Messages | Collapse Messages