Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1029683002: Update references to Mojo core and bindings (Closed)

Created:
5 years, 9 months ago by abarth-chromium
Modified:
5 years, 9 months ago
Reviewers:
zra, zra
CC:
mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Update references to Mojo core and bindings Build fix after recent Dart bindings refactoring. Now that these libraries are not included in the snapshot, we need to load them from the mojo package. R=zra@google.com TBR=zra@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/ea5a2e179d35d66657998989d8390bdabae7fff9

Patch Set 1 #

Patch Set 2 : shell.dart too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -9 lines) Patch
M sky/examples/terminal/terminal_file_impl.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/framework/net/fetch.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/framework/shell.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tools/shelldb View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
abarth-chromium
5 years, 9 months ago (2015-03-23 20:18:59 UTC) #1
zra
lgtm I don't anticipate further changes along these lines, but for reference, how should I ...
5 years, 9 months ago (2015-03-23 20:22:34 UTC) #3
abarth-chromium
Committed patchset #2 (id:20001) manually as ea5a2e179d35d66657998989d8390bdabae7fff9 (presubmit successful).
5 years, 9 months ago (2015-03-23 20:22:42 UTC) #4
abarth-chromium
5 years, 9 months ago (2015-03-23 20:25:23 UTC) #5
Message was sent while issue was closed.
On 2015/03/23 at 20:22:34, zra wrote:
> I don't anticipate further changes along these lines, but for reference, how
should I avoid breakage like this in the future?

The way I found these was to grep the code-base for the names of the libraries
you renamed.  Essentially,
s/'dart:mojo.core'/'package:mojo/public/dart/core.dart'/

Powered by Google App Engine
This is Rietveld 408576698