Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Side by Side Diff: content/browser/media/webrtc_browsertest.cc

Issue 1029663002: Sheriff: Fixing flaky test. See crbug.com/469819 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "base/files/file_util.h" 6 #include "base/files/file_util.h"
7 #include "base/strings/stringprintf.h" 7 #include "base/strings/stringprintf.h"
8 #include "base/threading/platform_thread.h" 8 #include "base/threading/platform_thread.h"
9 #include "content/browser/web_contents/web_contents_impl.h" 9 #include "content/browser/web_contents/web_contents_impl.h"
10 #include "content/public/common/content_switches.h" 10 #include "content/public/common/content_switches.h"
(...skipping 185 matching lines...) Expand 10 before | Expand all | Expand 10 after
196 " %s, {audio: true, video:true}, {audio: true});", 196 " %s, {audio: true, video:true}, {audio: true});",
197 kUseLenientAudioChecking)); 197 kUseLenientAudioChecking));
198 } 198 }
199 199
200 // Below 2 test will make a complete PeerConnection-based call between pc1 and 200 // Below 2 test will make a complete PeerConnection-based call between pc1 and
201 // pc2, and then use the remote stream to setup a call between pc3 and pc4, and 201 // pc2, and then use the remote stream to setup a call between pc3 and pc4, and
202 // then verify that video is received on pc3 and pc4. 202 // then verify that video is received on pc3 and pc4.
203 // The stream sent from pc3 to pc4 is the stream received on pc1. 203 // The stream sent from pc3 to pc4 is the stream received on pc1.
204 // The stream sent from pc4 to pc3 is cloned from stream the stream received 204 // The stream sent from pc4 to pc3 is cloned from stream the stream received
205 // on pc2. 205 // on pc2.
206 #if defined(THREAD_SANITIZER) 206 #if defined(THREAD_SANITIZER) || defined(OS_WIN)
207 // Flaky on TSAN v2. http://crbug.com/373637 207 // Flaky on TSAN v2. http://crbug.com/373637
208 // Flaky on Windows: http://crbug.com/469819
208 #define MAYBE_CanForwardRemoteStream DISABLED_CanForwardRemoteStream 209 #define MAYBE_CanForwardRemoteStream DISABLED_CanForwardRemoteStream
209 #define MAYBE_CanForwardRemoteStream720p DISABLED_CanForwardRemoteStream720p 210 #define MAYBE_CanForwardRemoteStream720p DISABLED_CanForwardRemoteStream720p
210 #else 211 #else
211 #define MAYBE_CanForwardRemoteStream CanForwardRemoteStream 212 #define MAYBE_CanForwardRemoteStream CanForwardRemoteStream
212 #define MAYBE_CanForwardRemoteStream720p CanForwardRemoteStream720p 213 #define MAYBE_CanForwardRemoteStream720p CanForwardRemoteStream720p
213 #endif 214 #endif
214 IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcBrowserTest, MAYBE_CanForwardRemoteStream) { 215 IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcBrowserTest, MAYBE_CanForwardRemoteStream) {
215 #if defined (OS_ANDROID) 216 #if defined (OS_ANDROID)
216 // This test fails on Nexus 5 devices. 217 // This test fails on Nexus 5 devices.
217 // TODO(henrika): see http://crbug.com/362437 and http://crbug.com/359389 218 // TODO(henrika): see http://crbug.com/362437 and http://crbug.com/359389
(...skipping 220 matching lines...) Expand 10 before | Expand all | Expand 10 after
438 439
439 IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcBrowserTest, CallAndVerifyVideoMutingWorks) { 440 IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcBrowserTest, CallAndVerifyVideoMutingWorks) {
440 MakeTypicalPeerConnectionCall("callAndEnsureVideoTrackMutingWorks();"); 441 MakeTypicalPeerConnectionCall("callAndEnsureVideoTrackMutingWorks();");
441 } 442 }
442 443
443 IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcBrowserTest, CreateOfferWithOfferOptions) { 444 IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcBrowserTest, CreateOfferWithOfferOptions) {
444 MakeTypicalPeerConnectionCall("testCreateOfferOptions();"); 445 MakeTypicalPeerConnectionCall("testCreateOfferOptions();");
445 } 446 }
446 447
447 } // namespace content 448 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698