Chromium Code Reviews| Index: components/metrics/call_stack_profile_metrics_provider_unittest.cc |
| diff --git a/components/metrics/call_stack_profile_metrics_provider_unittest.cc b/components/metrics/call_stack_profile_metrics_provider_unittest.cc |
| index c542c495c2ec2d7af1aaecdaf361d37d488eb6b8..c4b124d746cc22bfaef7575e854662d27bc77f67 100644 |
| --- a/components/metrics/call_stack_profile_metrics_provider_unittest.cc |
| +++ b/components/metrics/call_stack_profile_metrics_provider_unittest.cc |
| @@ -4,9 +4,11 @@ |
| #include "components/metrics/call_stack_profile_metrics_provider.h" |
| +#include "base/metrics/field_trial.h" |
| #include "base/profiler/stack_sampling_profiler.h" |
| #include "base/strings/string_number_conversions.h" |
| #include "components/metrics/proto/chrome_user_metrics_extension.pb.h" |
| +#include "components/variations/entropy_provider.h" |
| #include "testing/gtest/include/gtest/gtest.h" |
| using base::StackSamplingProfiler; |
| @@ -17,8 +19,32 @@ using Sample = StackSamplingProfiler::Sample; |
| namespace metrics { |
| +namespace { |
|
Ilya Sherman
2015/03/24 04:02:03
nit: Please leave a blank line here.
Mike Wittman
2015/03/24 18:37:39
Done.
|
| +class CallStackProfileMetricsProviderTest : public testing::Test { |
| + public: |
| + CallStackProfileMetricsProviderTest() {} |
| + ~CallStackProfileMetricsProviderTest() {} |
| + |
| + void SetUp() override { |
| + field_trial_list_.reset(new base::FieldTrialList( |
| + new metrics::SHA1EntropyProvider("foo"))); |
| + base::FieldTrialList::CreateFieldTrial( |
| + CallStackProfileMetricsProvider::kFieldTrialName, |
| + CallStackProfileMetricsProvider::kReportProfilesGroupName); |
| + } |
| + |
| + void TearDown() override { |
| + field_trial_list_.reset(); |
| + } |
| + |
| + private: |
| + scoped_ptr<base::FieldTrialList> field_trial_list_; |
| +}; |
| + |
| +} // namespace |
| + |
| // Checks that all properties from multiple profiles are filled as expected. |
| -TEST(CallStackProfileMetricsProviderTest, MultipleProfiles) { |
| +TEST_F(CallStackProfileMetricsProviderTest, MultipleProfiles) { |
| const uintptr_t module1_base_address = 0x1000; |
| const uintptr_t module2_base_address = 0x2000; |
| const uintptr_t module3_base_address = 0x3000; |
| @@ -229,7 +255,7 @@ TEST(CallStackProfileMetricsProviderTest, MultipleProfiles) { |
| // Checks that all duplicate samples are collapsed with |
| // preserve_sample_ordering = false. |
| -TEST(CallStackProfileMetricsProviderTest, RepeatedStacksUnordered) { |
| +TEST_F(CallStackProfileMetricsProviderTest, RepeatedStacksUnordered) { |
| const uintptr_t module_base_address = 0x1000; |
| const Module modules[] = { |
| @@ -305,7 +331,7 @@ TEST(CallStackProfileMetricsProviderTest, RepeatedStacksUnordered) { |
| // Checks that only contiguous duplicate samples are collapsed with |
| // preserve_sample_ordering = true. |
| -TEST(CallStackProfileMetricsProviderTest, RepeatedStacksOrdered) { |
| +TEST_F(CallStackProfileMetricsProviderTest, RepeatedStacksOrdered) { |
| const uintptr_t module_base_address = 0x1000; |
| const Module modules[] = { |
| @@ -381,7 +407,7 @@ TEST(CallStackProfileMetricsProviderTest, RepeatedStacksOrdered) { |
| // Checks that unknown modules produce an empty Entry. |
| -TEST(CallStackProfileMetricsProviderTest, UnknownModule) { |
| +TEST_F(CallStackProfileMetricsProviderTest, UnknownModule) { |
| // -1 indicates an unknown module. |
| const Frame frame(reinterpret_cast<const void*>(0x1000), -1); |