Enable startup profiling by Win x64 stack sampling profiler

components/metrics/call_stack_profile_metrics_provider_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/metrics/call_stack_profile_metrics_provider.h"
 
+#include "base/metrics/field_trial.h"
 #include "base/profiler/stack_sampling_profiler.h"
 #include "base/strings/string_number_conversions.h"
 #include "components/metrics/proto/chrome_user_metrics_extension.pb.h"
+#include "components/variations/entropy_provider.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using base::StackSamplingProfiler;
 using Frame = StackSamplingProfiler::Frame;
 using Module = StackSamplingProfiler::Module;
 using Profile = StackSamplingProfiler::Profile;
 using Sample = StackSamplingProfiler::Sample;
 
 namespace metrics {
 
+namespace {
+
+// This test fixture enables the field trial that
+// CallStackProfileMetricsProvider depends on to report profiles.
+class CallStackProfileMetricsProviderTest : public testing::Test {

[Ilya Sherman, 2015/03/24 21:07:55]

nit: I believe that test fixtures are supposed to be defined outside of the
anonymous namespace, because something something name mangling.

[Mike Wittman, 2015/03/24 22:40:59]

Yes, that sounds familiar.

+ public:
+  CallStackProfileMetricsProviderTest() {}
+  ~CallStackProfileMetricsProviderTest() {}
+
+  void SetUp() override {
+    field_trial_list_.reset(new base::FieldTrialList(
+        new metrics::SHA1EntropyProvider("foo")));
+    base::FieldTrialList::CreateFieldTrial(
+        FieldTrialState::kFieldTrialName,
+        FieldTrialState::kReportProfilesGroupName);
+  }
+
+  void TearDown() override {
+    field_trial_list_.reset();

[Ilya Sherman, 2015/03/24 21:07:55]

nit: No need to call this explicitly, unless it needs to happen before the test
fixture's destructor is called for some reason.

[Mike Wittman, 2015/03/24 22:40:59]

Removed. Also moved the SetUp contents into the constructor, which is preferred
according to the Google Test FAQ.

+  }
+
+ private:
+  // Exposes field trial/group names from the CallStackProfileMetricsProvider.
+  class FieldTrialState : public CallStackProfileMetricsProvider {
+   public:
+    using CallStackProfileMetricsProvider::kFieldTrialName;
+    using CallStackProfileMetricsProvider::kReportProfilesGroupName;
+  };
+
+  scoped_ptr<base::FieldTrialList> field_trial_list_;
+};
+
+}  // namespace
+
 // Checks that all properties from multiple profiles are filled as expected.
-TEST(CallStackProfileMetricsProviderTest, MultipleProfiles) {
+TEST_F(CallStackProfileMetricsProviderTest, MultipleProfiles) {
   const uintptr_t module1_base_address = 0x1000;
   const uintptr_t module2_base_address = 0x2000;
   const uintptr_t module3_base_address = 0x3000;
 
   const Module profile_modules[][2] = {
     {
       Module(
           reinterpret_cast<const void*>(module1_base_address),
           "ABCD",
 #if defined(OS_WIN)
@@ skipping 190 matching lines @@
     EXPECT_EQ(profile_durations[i].InMilliseconds(),
               call_stack_profile.profile_duration_ms());
     ASSERT_TRUE(call_stack_profile.has_sampling_period_ms());
     EXPECT_EQ(profile_sampling_periods[i].InMilliseconds(),
               call_stack_profile.sampling_period_ms());
   }
 }
 
 // Checks that all duplicate samples are collapsed with
 // preserve_sample_ordering = false.
-TEST(CallStackProfileMetricsProviderTest, RepeatedStacksUnordered) {
+TEST_F(CallStackProfileMetricsProviderTest, RepeatedStacksUnordered) {
   const uintptr_t module_base_address = 0x1000;
 
   const Module modules[] = {
     Module(
         reinterpret_cast<const void*>(module_base_address),
         "ABCD",
 #if defined(OS_WIN)
         base::FilePath(L"c:\\some\\path\\to\\chrome.exe")
 #else
         base::FilePath("/some/path/to/chrome")
@@ skipping 55 matching lines @@
       EXPECT_EQ(static_cast<uint64>(instruction_pointer - module_base_address),
                 entry.address());
       ASSERT_TRUE(entry.has_module_id_index());
       EXPECT_EQ(sample_frames[i][j].module_index, entry.module_id_index());
     }
   }
 }
 
 // Checks that only contiguous duplicate samples are collapsed with
 // preserve_sample_ordering = true.
-TEST(CallStackProfileMetricsProviderTest, RepeatedStacksOrdered) {
+TEST_F(CallStackProfileMetricsProviderTest, RepeatedStacksOrdered) {
   const uintptr_t module_base_address = 0x1000;
 
   const Module modules[] = {
     Module(
         reinterpret_cast<const void*>(module_base_address),
         "ABCD",
 #if defined(OS_WIN)
         base::FilePath(L"c:\\some\\path\\to\\chrome.exe")
 #else
         base::FilePath("/some/path/to/chrome")
@@ skipping 55 matching lines @@
       EXPECT_EQ(static_cast<uint64>(instruction_pointer - module_base_address),
                 entry.address());
       ASSERT_TRUE(entry.has_module_id_index());
       EXPECT_EQ(sample_frames[i][j].module_index, entry.module_id_index());
     }
   }
 }
 
 
 // Checks that unknown modules produce an empty Entry.
-TEST(CallStackProfileMetricsProviderTest, UnknownModule) {
+TEST_F(CallStackProfileMetricsProviderTest, UnknownModule) {
   // -1 indicates an unknown module.
   const Frame frame(reinterpret_cast<const void*>(0x1000), -1);
 
   Profile profile;
 
   profile.samples.push_back(Sample(1, frame));
 
   profile.profile_duration = base::TimeDelta::FromMilliseconds(100);
   profile.sampling_period = base::TimeDelta::FromMilliseconds(10);
   profile.preserve_sample_ordering = false;
@@ skipping 14 matching lines @@
       call_stack_profile.sample().Get(0);
   ASSERT_EQ(1, proto_sample.entry().size());
   ASSERT_TRUE(proto_sample.has_count());
   EXPECT_EQ(1u, proto_sample.count());
   const CallStackProfile::Entry& entry = proto_sample.entry().Get(0);
   EXPECT_FALSE(entry.has_address());
   EXPECT_FALSE(entry.has_module_id_index());
 }
 
 }  // namespace metrics