Enable startup profiling by Win x64 stack sampling profiler

components/metrics/call_stack_profile_metrics_provider.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/metrics/call_stack_profile_metrics_provider.h"
 
 #include <cstring>
 #include <map>
 #include <utility>
 
+#include "base/bind.h"
 #include "base/logging.h"
 #include "base/macros.h"
+#include "base/message_loop/message_loop_proxy.h"
+#include "base/metrics/field_trial.h"
 #include "base/profiler/stack_sampling_profiler.h"
 #include "components/metrics/metrics_hashes.h"
 #include "components/metrics/proto/chrome_user_metrics_extension.pb.h"
 
 using base::StackSamplingProfiler;
 
 namespace metrics {
 
 namespace {
 
+// Accepts and ignores the completed profiles. Used when metrics reporting is
+// disabled.
+void IgnoreCompletedProfiles(
+    const StackSamplingProfiler::CallStackProfiles& profiles) {
+}
+
 // The protobuf expects the MD5 checksum prefix of the module name.
 uint64 HashModuleFilename(const base::FilePath& filename) {
   const base::FilePath::StringType basename = filename.BaseName().value();
   // Copy the bytes in basename into a string buffer.
   size_t basename_length_in_bytes =
       basename.size() * sizeof(base::FilePath::CharType);
   std::string name_bytes(basename_length_in_bytes, '\0');
   memcpy(&name_bytes[0], &basename[0], basename_length_in_bytes);
   return HashMetricName(name_bytes);
 }
@@ skipping 64 matching lines @@
         proto_profile->add_module_id();
     module_id->set_build_id(module.id);
     module_id->set_name_md5_prefix(HashModuleFilename(module.filename));
   }
 
   proto_profile->set_profile_duration_ms(
       profile.profile_duration.InMilliseconds());
   proto_profile->set_sampling_period_ms(
       profile.sampling_period.InMilliseconds());
 }
+
 }  // namespace
 
-CallStackProfileMetricsProvider::CallStackProfileMetricsProvider() {}
+const char CallStackProfileMetricsProvider::kFieldTrialName[] =
+    "StackProfiling";
+const char CallStackProfileMetricsProvider::kReportProfilesGroupName[] =
+    "Report profiles";
 
-CallStackProfileMetricsProvider::~CallStackProfileMetricsProvider() {}
+CallStackProfileMetricsProvider::CallStackProfileMetricsProvider()
+    : weak_factory_(this) {
+}
+
+CallStackProfileMetricsProvider::~CallStackProfileMetricsProvider() {
+  StackSamplingProfiler::SetDefaultCompletedCallback(
+      StackSamplingProfiler::CompletedCallback());
+}
+
+void CallStackProfileMetricsProvider::OnRecordingEnabled() {
+  StackSamplingProfiler::SetDefaultCompletedCallback(
+      base::Bind(&CallStackProfileMetricsProvider::ReceiveCompletedProfiles,
+                 base::MessageLoopProxy::current(),
+                 weak_factory_.GetWeakPtr()));
+}
+
+void CallStackProfileMetricsProvider::OnRecordingDisabled() {
+  StackSamplingProfiler::SetDefaultCompletedCallback(
+      base::Bind(&IgnoreCompletedProfiles));
+  pending_profiles_.clear();
+}
 
 void CallStackProfileMetricsProvider::ProvideGeneralMetrics(
     ChromeUserMetricsExtension* uma_proto) {
-  std::vector<StackSamplingProfiler::CallStackProfile> profiles;
-  if (!source_profiles_for_test_.empty())
-    profiles.swap(source_profiles_for_test_);
-  else
-    StackSamplingProfiler::GetPendingProfiles(&profiles);
-
-  for (const StackSamplingProfiler::CallStackProfile& profile : profiles) {
+  DCHECK(IsSamplingProfilingReportingEnabled() || pending_profiles_.empty());
+  for (const StackSamplingProfiler::CallStackProfile& profile :
+       pending_profiles_) {
     CallStackProfile* call_stack_profile =
         uma_proto->add_sampled_profile()->mutable_call_stack_profile();
     CopyProfileToProto(profile, call_stack_profile);
   }
+  pending_profiles_.clear();

[Ilya Sherman, 2015/04/07 22:01:22]

Whoops!  Good catch!

Could you please add a test that would catch this error if it were to resurface?

[Mike Wittman, 2015/04/07 22:40:29]

Done.

 }
 
 void CallStackProfileMetricsProvider::SetSourceProfilesForTesting(
     const std::vector<StackSamplingProfiler::CallStackProfile>& profiles) {
-  source_profiles_for_test_ = profiles;
+  pending_profiles_ = profiles;
+}
+
+// static
+bool CallStackProfileMetricsProvider::IsSamplingProfilingReportingEnabled() {
+  const std::string group_name = base::FieldTrialList::FindFullName(
+      CallStackProfileMetricsProvider::kFieldTrialName);
+  return group_name ==
+      CallStackProfileMetricsProvider::kReportProfilesGroupName;
+}
+
+// static
+// Posts a message back to our own thread to collect the profiles.
+void CallStackProfileMetricsProvider::ReceiveCompletedProfiles(
+    scoped_refptr<base::MessageLoopProxy> message_loop,
+    base::WeakPtr<CallStackProfileMetricsProvider> provider,
+    const StackSamplingProfiler::CallStackProfiles& profiles) {
+  message_loop->PostTask(
+      FROM_HERE,
+      base::Bind(&CallStackProfileMetricsProvider::AppendCompletedProfiles,
+                 provider, profiles));
+}
+
+void CallStackProfileMetricsProvider::AppendCompletedProfiles(
+    const StackSamplingProfiler::CallStackProfiles& profiles) {
+  // Don't bother to record profiles if reporting is not enabled.
+  if (IsSamplingProfilingReportingEnabled())

[Ilya Sherman, 2015/04/07 22:01:22]

nit: Please use curlies, since the body of the stmt spans multiple lines.

[Mike Wittman, 2015/04/07 22:40:29]

Done.

+    pending_profiles_.insert(pending_profiles_.end(), profiles.begin(),
+                             profiles.end());
 }
 
 }  // namespace metrics