Chromium Code Reviews Chromium Code Reviews
Issue
102963007:
Make the Keystone tag contain -32bit and -full as needed (Closed)
DescriptionExpand the Keystone tag to contain the system's CPU's bitness and whether a
full installer is desired.
Formerly, the tag identified only the channel that Chrome was on. The tag is
being enhanced to detect the CPU's bitness (adding "-32bit" for 32-bit-only,
non-64-bit-capable CPUs) and whether a full (as opposed to binary diff patch)
update is requested (adding "-full").
CPU bitness detection ought to be a feature of Keystone, but Keystone uses the
NXGetLocalArchInfo to determine the CPU type, and winds up always reporting
"i486". The "-32bit" tag suffix will be present whenever the
"hw.cpu64bit_capable" sysctl name is not found or has value 0. This enables
proper detection of users who are capable of running 64-bit Chrome on the
server side.
When a binary diff patch update application fails in dirpatcher, typically the
result of modifications made to existing installations, the "-full" tag suffix
will be set. On a subsequent update attempt, the server can detect this value
and provide the client with a full updater package, which does not depend on
the existing installation. The "-full" tag suffix is cleared on successful
update installation.
BUG=18323, 54047, 225352, 303280, 316916
R=thakis@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242964
Patch Set 1 : #
Total comments: 12
Patch Set 2 : #
Total comments: 1
Patch Set 3 : #
Messages
Total messages: 7 (0 generated)
|
|||||||||||||||||||||||||||||||||||||
