Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 1029593004: Do not break lines when width is not specified. (Closed)

Created:
5 years, 9 months ago by Jun Mukai
Modified:
5 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not break lines when width is not specified. In case SetAllowCharacterBreak(true) is specified but width is not specified yet, nobody can stop gfx::ElideRectangleText() to wrap the text at very narrow width. But when the width is not specified, the ideal lines is expected (so that the label can be layouted based on the size). BUG=469559 R=sky@chromium.org TEST=the new test case covers Committed: https://crrev.com/4672257ac71a14be683b4f5a4b54a402cf0e493b Cr-Commit-Position: refs/heads/master@{#321854}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -4 lines) Patch
M ui/views/controls/label.cc View 1 chunk +11 lines, -4 lines 0 comments Download
M ui/views/controls/label_unittest.cc View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Jun Mukai
5 years, 9 months ago (2015-03-23 17:48:59 UTC) #1
sky
LGTM
5 years, 9 months ago (2015-03-23 19:19:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1029593004/1
5 years, 9 months ago (2015-03-23 19:21:47 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-23 21:22:27 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 21:22:51 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4672257ac71a14be683b4f5a4b54a402cf0e493b
Cr-Commit-Position: refs/heads/master@{#321854}

Powered by Google App Engine
This is Rietveld 408576698