Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Issue 1029583007: Use the outermost embedder WebContents in ConstrainedWindowMac. (Closed)

Created:
5 years, 9 months ago by Sam McNally
Modified:
5 years, 9 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use the outermost embedder WebContents in ConstrainedWindowMac. Currently, ConstrainedWindowMac uses the embedder WebContents of the GuestView if the WebContents is in a GuestView. However, with OOP PDF, a mime handler view can be embedded in a webview that is embedded in an app window; in this case, the webview WebContents is used instead of the app window WebContents. This CL changes ConstrainedWindowMac to use the outermost embedder WebContents. This is the same fix as http://crrev.com/321248, but for mac. BUG=457672 Committed: https://crrev.com/0a61f800e27e0e9a369d27a7e69dc8d9d90fccde Cr-Commit-Position: refs/heads/master@{#322305}

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm View 1 chunk +9 lines, -6 lines 1 comment Download

Messages

Total messages: 11 (4 generated)
Sam McNally
5 years, 9 months ago (2015-03-25 00:10:32 UTC) #3
Mark Mentovai
LGTM
5 years, 9 months ago (2015-03-25 16:13:34 UTC) #4
Mark Mentovai
Be careful with the trybot test failures.
5 years, 9 months ago (2015-03-25 16:14:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1029583007/20001
5 years, 9 months ago (2015-03-26 01:30:20 UTC) #7
Fady Samuel
https://codereview.chromium.org/1029583007/diff/20001/chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm File chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm (right): https://codereview.chromium.org/1029583007/diff/20001/chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm#newcode26 chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm:26: while (extensions::GuestViewBase* guest_view = Drive by comment: This pattern ...
5 years, 9 months ago (2015-03-26 01:43:02 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 9 months ago (2015-03-26 02:42:32 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 02:43:41 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0a61f800e27e0e9a369d27a7e69dc8d9d90fccde
Cr-Commit-Position: refs/heads/master@{#322305}

Powered by Google App Engine
This is Rietveld 408576698