Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 1029583003: [Icons NTP] Make Fast Local NTP render largeIconUrl instead of thumbnail, if available. (Closed)

Created:
5 years, 9 months ago by huangs
Modified:
5 years, 9 months ago
Reviewers:
Mathieu, fserb
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, arv+watch_chromium.org, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Icons NTP] Make Fast Local NTP render largeIconUrl instead of thumbnail, if available. This is the fast local NTP counterpart to https://crrev.com/1013173003. BUG=467712 Committed: https://crrev.com/b76334fe1d7db68c5eae1012008f031560295ca2 Cr-Commit-Position: refs/heads/master@{#321861}

Patch Set 1 #

Patch Set 2 : Sync. #

Patch Set 3 : A bit of renaming to reduce ambiguity. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -6 lines) Patch
M chrome/browser/resources/local_ntp/most_visited_single.css View 1 2 1 chunk +13 lines, -2 lines 0 comments Download
M chrome/browser/resources/local_ntp/most_visited_single.js View 1 2 1 chunk +13 lines, -2 lines 0 comments Download
M chrome/browser/resources/local_ntp/most_visited_thumbnail.css View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
huangs
PTAL.
5 years, 9 months ago (2015-03-23 18:47:59 UTC) #2
Mathieu
lgtm
5 years, 9 months ago (2015-03-23 18:50:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1029583003/40001
5 years, 9 months ago (2015-03-23 21:36:48 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-23 21:41:42 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 21:42:55 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b76334fe1d7db68c5eae1012008f031560295ca2
Cr-Commit-Position: refs/heads/master@{#321861}

Powered by Google App Engine
This is Rietveld 408576698