Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1029553002: [DevTools] Introduce Unregister/Start/Stop/Inspect buttons to ServiceWorkersView [1/2 chromium] (Closed)

Created:
5 years, 9 months ago by horo
Modified:
5 years, 9 months ago
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, serviceworker-reviews, tzik, horo+watch_chromium.org, jam, yurys, darin-cc_chromium.org, nhiroki, devtools-reviews_chromium.org, kinuko+serviceworker, kinuko+watch, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Introduce Unregister/Start/Stop/Inspect buttons to ServiceWorkersView [1/2 chromium] 1/2 chromium: this cl 2/2 blink: https://codereview.chromium.org/1023293004/ Screen shot: https://code.google.com/p/chromium/issues/detail?id=466871#c9 BUG=466871 Committed: https://crrev.com/8f542eaffaa599f2a35501693c578e4249c47123 Cr-Commit-Position: refs/heads/master@{#321920}

Patch Set 1 : #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : fix indent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -38 lines) Patch
M content/browser/devtools/protocol/service_worker_handler.h View 2 chunks +6 lines, -0 lines 0 comments Download
M content/browser/devtools/protocol/service_worker_handler.cc View 1 2 4 chunks +101 lines, -13 lines 0 comments Download
M content/browser/service_worker/service_worker_context_wrapper.h View 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_context_wrapper.cc View 3 chunks +46 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_internals_ui.cc View 2 chunks +1 line, -25 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
horo
pfeldman@ Could you please review content/browser/devtools/protocol/service_worker_handler.*? ksakamoto@ Could you please review content/browser/service_worker/service_worker_*?
5 years, 9 months ago (2015-03-23 10:48:55 UTC) #3
pfeldman
devtools lgtm https://codereview.chromium.org/1029553002/diff/30001/content/browser/devtools/protocol/service_worker_handler.cc File content/browser/devtools/protocol/service_worker_handler.cc (right): https://codereview.chromium.org/1029553002/diff/30001/content/browser/devtools/protocol/service_worker_handler.cc#newcode159 content/browser/devtools/protocol/service_worker_handler.cc:159: ServiceWorkerContextCore* context_core = context->context(); poor indentation.
5 years, 9 months ago (2015-03-23 12:10:09 UTC) #4
horo
Thank you https://codereview.chromium.org/1029553002/diff/30001/content/browser/devtools/protocol/service_worker_handler.cc File content/browser/devtools/protocol/service_worker_handler.cc (right): https://codereview.chromium.org/1029553002/diff/30001/content/browser/devtools/protocol/service_worker_handler.cc#newcode159 content/browser/devtools/protocol/service_worker_handler.cc:159: ServiceWorkerContextCore* context_core = context->context(); On 2015/03/23 12:10:09, ...
5 years, 9 months ago (2015-03-23 12:22:46 UTC) #5
Kunihiko Sakamoto
content/browser/service_worker lgtm
5 years, 9 months ago (2015-03-24 00:13:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1029553002/50001
5 years, 9 months ago (2015-03-24 00:28:58 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:50001)
5 years, 9 months ago (2015-03-24 01:41:53 UTC) #13
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 01:42:57 UTC) #14
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/8f542eaffaa599f2a35501693c578e4249c47123
Cr-Commit-Position: refs/heads/master@{#321920}

Powered by Google App Engine
This is Rietveld 408576698