Make the textfield in app_list and find_bar not support suggestions.

Make the textfield in app_list and find_bar not support suggestions.

The physical keyboard autocorrect feature (crbug.com/422869) is targeted to
be launched in M43.
The feature should be turned off if the input field is marked as
autocorrect==off, which is only supported by web input field for now.

This cl is to make certain native fields (views::TextField) to be marked
as autocorrect==off so that physical keyboard autocorrect feature can
stop working on it.

Note: this cl will also impact virtual keyboard. The suggestions on virtual
keyboard will also stop working on those input fields.

BUG=455865
TEST=Verified on linux_chromeos.

Committed: https://crrev.com/cee6bbcd8e49c782db710a58e6c9c4d78741c868
Cr-Commit-Position: refs/heads/master@{#322319}

[Shu Chen, 2015-03-23 08:23:23]

shuchen@chromium.org changed reviewers:
+ msw@chromium.org, sadrul@chromium.org

[Shu Chen, 2015-03-23 08:23:24]

Hi Mike/Sadrul, can you please review this cl? Thanks

[Shu Chen, 2015-03-23 08:24:02]

Cc'ed stevet@ for the impact of virtual keyboard.

[SteveT, 2015-03-23 13:06:07]

On 2015/03/23 08:24:02, Shu Chen wrote:
> Cc'ed stevet@ for the impact of virtual keyboard.

Shu will this just turn off suggestions, or will it hide the bar as well? (I am
guessing the former)

[msw, 2015-03-23 19:43:00]

Interesting; lgtm.

[sadrul, 2015-03-23 19:52:05]

sadrul@chromium.org changed reviewers:
+ mgiuca@chromium.org
- sadrul@chromium.org

[sadrul, 2015-03-23 19:52:05]

Replacing myself with mguica@ for app-list owner

[Shu Chen, 2015-03-24 00:46:21]

On 2015/03/23 13:06:07, SteveT wrote:
> On 2015/03/23 08:24:02, Shu Chen wrote:
> > Cc'ed stevet@ for the impact of virtual keyboard.
> 
> Shu will this just turn off suggestions, or will it hide the bar as well? (I
am
> guessing the former)

Yes, just turn off the suggestions, the suggestion bar will not be hidden.

[Shu Chen, 2015-03-25 04:37:09]

Pinging...

Matt, can you please take a look at your early convenience?

Thanks

[Matt Giuca, 2015-03-25 06:04:15]

Code-wise, app_list lgtm.

But I'm wondering about the philosophical reason behind this. Is it to save
vertical space? Or just that suggestions are not considered appropriate here?
I've always been baffled and, frankly, irritated that the Android keyboard does
not offer suggestions while typing into the Google Search app. Just because the
search app is offering suggestions (usually suffix matches) doesn't mean it
isn't also helpful to have keyboard suggestions (which might be suggesting
different words with keys physically close to what I typed on the keyboard).

Anyway, just my 2c, curious to hear your thoughts, but go ahead and commit this
if it's already been decided that we want to remove suggestions from the
vkeyboard in the app list.

[Shu Chen, 2015-03-26 02:17:48]

On 2015/03/25 06:04:15, Matt Giuca wrote:
> Code-wise, app_list lgtm.
> 
> But I'm wondering about the philosophical reason behind this. Is it to save
> vertical space? Or just that suggestions are not considered appropriate here?
> I've always been baffled and, frankly, irritated that the Android keyboard
does
> not offer suggestions while typing into the Google Search app. Just because
the
> search app is offering suggestions (usually suffix matches) doesn't mean it
> isn't also helpful to have keyboard suggestions (which might be suggesting
> different words with keys physically close to what I typed on the keyboard).
> 
> Anyway, just my 2c, curious to hear your thoughts, but go ahead and commit
this
> if it's already been decided that we want to remove suggestions from the
> vkeyboard in the app list.

Thanks for your l-g-t-m, Matt.

There is 2 reasons:
1) The physical keyboard autocorrect tries to pop up suggestions UI right below
the cursor, so if the input field has its own suggestions, there would be
overlaps.
2) The physical keyboard autocorrect tries to set composition text in the input
field, for find_bar box, setting composition text won't trigger "find in page"
action until the composition text is committed.

But anyway, it is up to IMEs to decide whether to provide suggestions so at
least the information should be exposed to IMEs.

[Shu Chen, 2015-03-26 02:23:49]

The CQ bit was checked by shuchen@chromium.org

[commit-bot: I haz the power, 2015-03-26 02:23:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1029543002/1

[commit-bot: I haz the power, 2015-03-26 04:36:27]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-03-26 04:37:13]

Patchset 1 (id:??) landed as
https://crrev.com/cee6bbcd8e49c782db710a58e6c9c4d78741c868
Cr-Commit-Position: refs/heads/master@{#322319}