content/browser/devtools/forwarding_agent_host.cc - Issue 1029523002: DevTools: Enable network emulation on Service Workers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/forwarding_agent_host.cc

Issue 1029523002: DevTools: Enable network emulation on Service Workers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/devtools/devtools_agent_host_impl.cc ('K') | « content/browser/devtools/forwarding_agent_host.h ('k') | content/browser/devtools/ipc_devtools_agent_host.h » ('j') | content/browser/devtools/ipc_devtools_agent_host.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/forwarding_agent_host.cc

diff --git a/content/browser/devtools/forwarding_agent_host.cc b/content/browser/devtools/forwarding_agent_host.cc

index db8af96a2b1f5df3a82b20eaade3dea4aaca62d9..98e583280e110332876b21512df73615cbe02461 100644

--- a/content/browser/devtools/forwarding_agent_host.cc

+++ b/content/browser/devtools/forwarding_agent_host.cc

@@ -40,10 +40,13 @@ void ForwardingAgentHost::Detach() {

delegate_->Detach();

}

-void ForwardingAgentHost::DispatchProtocolMessage(

+bool ForwardingAgentHost::DispatchProtocolMessage(

const std::string& message) {

- if (delegate_)

+ if (delegate_) {

delegate_->SendMessageToBackend(message);

+ return true;

+ }

+ return false;

pfeldman 2015/03/23 09:59:01 you should always report this command as handled.

Kunihiko Sakamoto 2015/03/23 10:23:58 Done.

}

DevToolsAgentHost::Type ForwardingAgentHost::GetType() {