Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(991)

Unified Diff: net/tools/quic/quic_time_wait_list_manager_test.cc

Issue 1029463003: Improve tests. Correct things clang_tidy complains about. Make (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/tools/quic/quic_time_wait_list_manager.cc ('k') | net/tools/quic/test_tools/quic_test_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/quic_time_wait_list_manager_test.cc
diff --git a/net/tools/quic/quic_time_wait_list_manager_test.cc b/net/tools/quic/quic_time_wait_list_manager_test.cc
index 724f60170872a21eb46bc0c276a6a9e2f25eac3f..7eb072aa9f0b1bd1786cd424d5ef413ae3b97c9f 100644
--- a/net/tools/quic/quic_time_wait_list_manager_test.cc
+++ b/net/tools/quic/quic_time_wait_list_manager_test.cc
@@ -69,7 +69,7 @@ class QuicTimeWaitListManagerPeer {
}
static QuicTime::Delta time_wait_period(QuicTimeWaitListManager* manager) {
- return manager->kTimeWaitPeriod_;
+ return manager->time_wait_period_;
}
static QuicVersion GetQuicVersionFromConnectionId(
@@ -228,7 +228,7 @@ TEST_F(QuicTimeWaitListManagerTest, CheckConnectionIdInTimeWait) {
}
TEST_F(QuicTimeWaitListManagerTest, SendConnectionClose) {
- size_t kConnectionCloseLength = 100;
+ const size_t kConnectionCloseLength = 100;
EXPECT_CALL(visitor_, OnConnectionAddedToTimeWaitList(connection_id_));
AddConnectionId(
connection_id_,
@@ -283,7 +283,7 @@ TEST_F(QuicTimeWaitListManagerTest, CleanUpOldConnectionIds) {
const size_t kConnectionIdCount = 100;
const size_t kOldConnectionIdCount = 31;
- // Add connection_ids such that their expiry time is kTimeWaitPeriod_.
+ // Add connection_ids such that their expiry time is time_wait_period_.
epoll_server_.set_now_in_usec(0);
for (size_t connection_id = 1; connection_id <= kOldConnectionIdCount;
++connection_id) {
@@ -293,7 +293,7 @@ TEST_F(QuicTimeWaitListManagerTest, CleanUpOldConnectionIds) {
EXPECT_EQ(kOldConnectionIdCount, time_wait_list_manager_.num_connections());
// Add remaining connection_ids such that their add time is
- // 2 * kTimeWaitPeriod.
+ // 2 * time_wait_period_.
const QuicTime::Delta time_wait_period =
QuicTimeWaitListManagerPeer::time_wait_period(&time_wait_list_manager_);
epoll_server_.set_now_in_usec(time_wait_period.ToMicroseconds());
@@ -418,12 +418,12 @@ TEST_F(QuicTimeWaitListManagerTest, GetQuicVersionFromMap) {
}
TEST_F(QuicTimeWaitListManagerTest, AddConnectionIdTwice) {
- // Add connection_ids such that their expiry time is kTimeWaitPeriod_.
+ // Add connection_ids such that their expiry time is time_wait_period_.
epoll_server_.set_now_in_usec(0);
EXPECT_CALL(visitor_, OnConnectionAddedToTimeWaitList(connection_id_));
AddConnectionId(connection_id_);
EXPECT_TRUE(IsConnectionIdInTimeWait(connection_id_));
- size_t kConnectionCloseLength = 100;
+ const size_t kConnectionCloseLength = 100;
AddConnectionId(
connection_id_,
QuicVersionMax(),
« no previous file with comments | « net/tools/quic/quic_time_wait_list_manager.cc ('k') | net/tools/quic/test_tools/quic_test_utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698