Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Unified Diff: net/tools/quic/quic_time_wait_list_manager.h

Issue 1029463003: Improve tests. Correct things clang_tidy complains about. Make (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/tools/quic/quic_dispatcher_test.cc ('k') | net/tools/quic/quic_time_wait_list_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/quic_time_wait_list_manager.h
diff --git a/net/tools/quic/quic_time_wait_list_manager.h b/net/tools/quic/quic_time_wait_list_manager.h
index fe5f020a263a273df276bb71b66160b1a764b160..fb1619c155607eeb2e9fd9f4fe0a731ac7b8226d 100644
--- a/net/tools/quic/quic_time_wait_list_manager.h
+++ b/net/tools/quic/quic_time_wait_list_manager.h
@@ -35,7 +35,7 @@ class QuicTimeWaitListManagerPeer;
} // namespace test
// Maintains a list of all connection_ids that have been recently closed. A
-// connection_id lives in this state for kTimeWaitPeriod. All packets received
+// connection_id lives in this state for time_wait_period_. All packets received
// for connection_ids in this state are handed over to the
// QuicTimeWaitListManager by the QuicDispatcher. Decides whether to send a
// public reset packet, a copy of the previously sent connection close packet,
@@ -54,15 +54,17 @@ class QuicTimeWaitListManager : public QuicBlockedWriterInterface {
const QuicVersionVector& supported_versions);
~QuicTimeWaitListManager() override;
- // Adds the given connection_id to time wait state for kTimeWaitPeriod.
+ // Adds the given connection_id to time wait state for time_wait_period_.
// Henceforth, any packet bearing this connection_id should not be processed
// while the connection_id remains in this list. If a non-nullptr
- // |close_packet| is provided, it is sent again when packets are received for
- // added connection_ids. If nullptr, a public reset packet is sent with the
- // specified |version|. DCHECKs that connection_id is not already on the list.
- void AddConnectionIdToTimeWait(QuicConnectionId connection_id,
- QuicVersion version,
- QuicEncryptedPacket* close_packet); // Owned.
+ // |close_packet| is provided, the TimeWaitListManager takes ownership of it
+ // and sends it again when packets are received for added connection_ids. If
+ // nullptr, a public reset packet is sent with the specified |version|.
+ // DCHECKs that connection_id is not already on the list. "virtual" to
+ // override in tests.
+ virtual void AddConnectionIdToTimeWait(QuicConnectionId connection_id,
+ QuicVersion version,
+ QuicEncryptedPacket* close_packet);
// Returns true if the connection_id is in time wait state, false otherwise.
// Packets received for this connection_id should not lead to creation of new
@@ -173,7 +175,7 @@ class QuicTimeWaitListManager : public QuicBlockedWriterInterface {
EpollServer* epoll_server_;
// Time period for which connection_ids should remain in time wait state.
- const QuicTime::Delta kTimeWaitPeriod_;
+ const QuicTime::Delta time_wait_period_;
// Alarm registered with the epoll server to clean up connection_ids that have
// out lived their duration in time wait state.
« no previous file with comments | « net/tools/quic/quic_dispatcher_test.cc ('k') | net/tools/quic/quic_time_wait_list_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698