Issue 1029463003: Improve tests. Correct things clang_tidy complains about. Make

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1029463003: Improve tests. Correct things clang_tidy complains about. Make (Closed)

Created:
5 years, 9 months ago by ramant (doing other things)

Modified:
5 years, 9 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Improve tests. Correct things clang_tidy complains about. Make QuicTimeWaitListManager::AddConnectionIdToTimeWait virtual so it can be mocked. Correct things clang_tidy complains about. Make a method virtual so it can be mocked. Merge internal change: 88744988 R=rch@chromium.org

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+83 lines, -66 lines)			Patch
M	net/quic/quic_time_wait_list_manager.h	View	3 chunks	+11 lines, -9 lines	0 comments	Download
M	net/quic/quic_time_wait_list_manager.cc	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	net/tools/quic/quic_dispatcher_test.cc	View	8 chunks	+16 lines, -27 lines	0 comments	Download
M	net/tools/quic/quic_time_wait_list_manager.h	View	3 chunks	+11 lines, -9 lines	0 comments	Download
M	net/tools/quic/quic_time_wait_list_manager.cc	View	3 chunks	+9 lines, -9 lines	0 comments	Download
M	net/tools/quic/quic_time_wait_list_manager_test.cc	View	5 chunks	+6 lines, -6 lines	0 comments	Download
M	net/tools/quic/test_tools/quic_test_utils.h	View	1 chunk	+14 lines, -0 lines	0 comments	Download
M	net/tools/quic/test_tools/quic_test_utils.cc	View	2 chunks	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ramant (doing other things)

5 years, 9 months ago (2015-03-24 21:15:28 UTC) #3

On 2015/03/22 17:09:07, Ryan Hamilton wrote:
> lgtm

Closing the issue. The following CL is being merged.

https://codereview.chromium.org/1034573002/

Expand Messages | Collapse Messages