Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1029423011: [Enhanced Bookmark] Change "Bookmark Bar" to "Bookmark bar" on Android (Closed)

Created:
5 years, 9 months ago by Ian Wen
Modified:
5 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Enhanced Bookmark] Change "Bookmark Bar" to "Bookmark bar" on Android Upper case letters for all words is not Android style. BUG=NONE Committed: https://crrev.com/4f788f0229be905dc611b90640e2447134a20139 Cr-Commit-Position: refs/heads/master@{#322603}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/bookmark_bar_strings.grdp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Ian Wen
5 years, 9 months ago (2015-03-26 20:56:27 UTC) #2
sky
LGTM
5 years, 8 months ago (2015-03-27 15:31:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1029423011/1
5 years, 8 months ago (2015-03-27 16:52:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-03-27 17:58:42 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-03-27 17:59:31 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4f788f0229be905dc611b90640e2447134a20139
Cr-Commit-Position: refs/heads/master@{#322603}

Powered by Google App Engine
This is Rietveld 408576698